Repository navigation
docs(mcpx): decision 0005 — release pipeline, version single-sourcing, module path (#1881) - #2532
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 379dcfcdc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The nix package keeps its own (cgo) build: it targets managed systems | ||
| where NSS is the point, and it already exists. |
There was a problem hiding this comment.
The Nix package already sets env.CGO_ENABLED = "0" in pkgs/mcpx/package.nix:60, both at this commit and at the cited baseline 7d1b081c; it does not have the cgo build this decision says it preserves. Because this note governs the implementation slices, following this policy would either unexpectedly re-enable cgo despite §2 promising only a version-source change, or leave the stated NSS behavior incorrect. Preserve the actual static configuration in the decision, or explicitly describe enabling cgo as a separate behavior change.
Useful? React with 👍 / 👎.
Slice 1 of #1881 (queue task 3114): the committed design note the rest of the release work builds to.
docs/decisions/0005 — Release pipeline, version single-sourcing, and the module path (status: proposed, per the decisions README convention), indexed in docs/decisions/README.md.
What it decides, from state verified at 7d1b081:
curl | shinstaller (per-user default, checksum-verifying) → GHCR container image → nix (already works). Flatpak is not built — a sandboxed mcpx cannot spawn the arbitrary servers/runtimes that are its function; mcpx: release.yaml, release artifacts and the install channels the docs will promise #1881's recommendation against is recorded as a decision.mcpx/vX.Y.Ztags; apkgs/mcpx/VERSIONfile as the single source consumed by package.nix (version + ldflags), the Containerfile build-arg and the release workflow (which refuses a tag/VERSION mismatch);main.go's fallback becomes a0.0.0-devsentinel.CGO_ENABLED=0(the Phase 5: tag event bodies must travel with the event #182-verified build), with the Linux NSS/LDAP caveat written down; the nix package keeps its cgo build.github.com/developing-today/code/pkgs/mcpx, one mechanical pass over 328 files), C (release-only mirror — not recommended). Recommendation: B, now — it makesgo installand the homepage true with no new repository and does not close A's door.Remaining slices of task 3114 (version wiring → rename → release workflow + snapshot proof → installer + CI exercise → container publication + #1878 status column) are enumerated in §6 of the note; the task is parked on this PR, not done.
Need help on this PR? Tag
@codesmith-botwith what you need.