Skip to content

fix(id): carry emphasis/strong/strikethrough marks wrapping images through the markdown codec (#1407) - #1630

Merged
dezren39 merged 1 commit into
mainfrom
queue/1477-1407-image-marks
Oct 28, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/1477-1407-image-marks

Conversation

@dezren39

@dezren39 dezren39 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Fixes #1407.

Approach (follows the #880 attr precedent)

Combined spelling note: canonical nesting puts the link outermost, so *[![alt](src)](href)* saves as [*![alt](src)*](href) — the same canonicalization the codec already applies to marked text — and re-parses to the identical node (fixpoint tested).

Editor note: no editor.ts change — the representation is codec-side (marks on the image node, mirroring text nodes); the editor schema does not wrap image nodes in marks today, the known limitation the #880 precedent already documents for links.

Tests

New codec regression tests: image-only spans for *, **, ~~ in both directions with fixpoint; combined marked+linked image; mixed *text ![alt](img.png) tail* saving as one span with no  .

Verified on the laptop: cargo test --features web --lib web::markdown — 103 passed, 0 failed. Full suite runs in CI on this PR (fleet CI-first policy).

Queue task 1477.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 28, 2026 09:02
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 56a4b06d-f1bc-4e76-8f39-2bfea58ffaca
Commits

Reviewing files that changed from the base of the PR and between 1f0722c and 19abd7d.

Files selected for processing: 1
  • pkgs/id/src/web/markdown.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T09:04:43.716971Z 19abd7d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit 7eb930a into main Oct 28, 2026
33 checks passed
@dezren39
dezren39 deleted the queue/1477-1407-image-marks branch October 28, 2026 11:31
@dezren39
dezren39 restored the queue/1477-1407-image-marks branch November 1, 2026 07:48
@dezren39
dezren39 deleted the queue/1477-1407-image-marks branch November 1, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities

1 participant