id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities

Summary

In pkgs/id's web markdown codec, a mark that wraps an image (emphasis, strong, strikethrough) is silently lost. When the mark wraps only an image, it disappears entirely; when it wraps text plus an image, the saved markdown splits the mark around the image and leaks literal   HTML entities into the file.

Evidence (verified this run on main `37418e56`)

Probe: verbatim copy of pkgs/id/src/web/markdown.rs in a standalone crate (comrak 0.56.0), hidden_files/probe-2026-10-27-creator-a4/out4.log:

Input	Saved output
`![alt](/x.png)`	`![alt](/x.png)` — emphasis gone
`![alt](/x.png)`	`![alt](/x.png)` — strong gone
`~~![alt](/x.png)~~`	`![alt](/x.png)` — strikethrough gone
`[![alt](/x.png)](https://e.com)`	`[![alt](/x.png)](https://e.com)` — link survives, emphasis gone
`text ![alt](/x.png) tail`	`text ![alt](/x.png)* tail*` — one emphasis span becomes two, with literal ` ` entities in the saved file, and the image is no longer inside either span's text (re-parse gives the same split PM, so it is stable corruption, not a fixpoint error)
`text ![alt](/x.png) tail`	`text ![alt](/x.png) tail` — same for strong
`- ![alt](/x.png) item`	`- ![alt](/x.png) item` — same loss inside list items

Control: *text only* round-trips exactly. The parsed ProseMirror for *![alt](/x.png)* is a bare image node with no marks at all ({"type":"image","attrs":{"alt":"alt","src":"/x.png"}}).

Root cause

Parse direction: the NodeValue::Image arm in convert_node (pkgs/id/src/web/markdown.rs:354-393) receives the surrounding marks in active_marks but only carries the link mark forward, copying it into the image node's linkHref/linkTitle attrs (the id(web): linked images [![alt](src)](href) lose their link in the markdown ↔ ProseMirror codec — save strips the href #880 precedent). em / strong / strikethrough marks in active_marks are ignored, and the emitted image node has no representation for them.
Save direction: the "image" arm of json_to_ast (pkgs/id/src/web/markdown.rs:1308-1360) and the post-processing wrap (:1503-1519) only know how to re-wrap an image in a Link node from linkHref; there is no equivalent for emphasis/strong/strikethrough, and the marked text runs on either side of the image are emitted as separate mark-wrapper nodes, whose boundary spaces comrak escapes as  .

Why it matters

Italic/bold captions and callouts that include an inline image are ordinary markdown (common in notes imported from other tools, which id syncs as plain files). Today such a document loses its formatting on the first open→save, and the mixed text+image case additionally writes   entities into the user's file — visible garbage in any other editor. The loss is silent: no error, and the result is a stable fixpoint, so nothing downstream notices.

Acceptance criteria

*![alt](/x.png)*, **![alt](/x.png)**, ~~![alt](/x.png)~~ and the linked-image form *[![alt](/x.png)](href)* round-trip with the mark preserved (exact markdown or an equivalent form that re-parses to the same marked structure, with no mark loss).
*text ![alt](/x.png) tail* (and the strong/strikethrough equivalents) save as a single emphasis span containing the image, with no   or other HTML entities introduced into the saved markdown.
The representation chosen is coherent with the existing id(web): linked images [![alt](src)](href) lose their link in the markdown ↔ ProseMirror codec — save strips the href #880 linkHref/linkTitle pattern for wrapping an image, and the editor either renders it or the limitation is explicitly documented in the issue's resolution.
Regression tests in pkgs/id/src/web/markdown.rs cover image-only and mixed text+image mark spans in both directions; existing web::markdown tests still pass.

Related: #880 (linked images carried via attrs — the pattern to extend), #1045 (unknown marks dropped on save — a different, text-node policy question), #968 (mark re-nesting for text runs).

CODE-498

🤖 Agent note · state: filed

Agent: new-issue-creator job (lane A, slug new-issue-creator-code-a)
Session / ID: cron new-issue-creator-code-a, run 2026-10-27 06:18 CDT
Found via: filed this run
Task: Filed after verification on main 37418e5 with a verbatim-codec probe crate (comrak 0.56.0): marks wrapping an image are dropped at parse (Image arm ignores non-link active_marks), and mixed text+image spans save split with literal entities.
Expectation: effort/s — triage picks the representation (extend the id(web): linked images [![alt](src)](href) lose their link in the markdown ↔ ProseMirror codec — save strips the href #880 attr-carry pattern or give the image node real marks), then fix with regression tests both directions.
Links: probe log hidden_files/probe-2026-10-27-creator-a4/out4.log; body source hidden_files/issue-code-id-image-marks-body.md

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), Lane B shift
Session / ID: queue task 1396
Found via: queue claim
Task: Triage id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities #1407 — verify the codec evidence on current main (marks wrapping images dropped; mixed spans split with ), confirm or refute, and route a follow-up fix task
Expectation: effort s — findings comment on id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities #1407 and, if confirmed, a small_fix follow-up enqueued
Links: issue id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities #1407

Queue task 1477 parked on CI again (Lane B): PR #1630 stands at 31 SUCCESS / 0 FAILURE with only the aggregate 'nix flake check' job still QUEUED (runner stall #1599). Resume = merge PR #1630 when the aggregate flips green, then complete fixed_merged.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane C shift
Session / ID: queue task 1477
Found via: queue claim (resume from parked awaiting_ci)
Task: Resumed PR fix(id): carry emphasis/strong/strikethrough marks wrapping images through the markdown codec (#1407) #1630 @19abd7df — 31 checks pass / 0 fail, only the aggregate nix flake check job still pending. Polling briefly, then merge on green.
Expectation: effort s — done = PR merged, issue closed, task completed fixed_merged.
Links: PR fix(id): carry emphasis/strong/strikethrough marks wrapping images through the markdown codec (#1407) #1630

fix(id): carry emphasis/strong/strikethrough marks wrapping images th…

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane C shift
Session / ID: queue task 1477
Found via: queue claim (resume from parked awaiting_ci)
Task: PR fix(id): carry emphasis/strong/strikethrough marks wrapping images through the markdown codec (#1407) #1630 merged — emphasis/strong/strikethrough marks wrapping images now carry through the markdown codec (markdown.rs). CI: 32 pass incl. aggregate nix flake check, 0 fail.
Expectation: done — PR merged 7eb930a, issue closed.
Links: PR fix(id): carry emphasis/strong/strikethrough marks wrapping images through the markdown codec (#1407) #1630

Navigation Menu

Repository navigation

id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak   entities #1407

Summary

Evidence (verified this run on main `37418e56`)

Root cause

Why it matters

Acceptance criteria

25 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak &#32; entities #1407

Description

Summary

Evidence (verified this run on main 37418e56)

Root cause

Why it matters

Acceptance criteria

Activity

developing-today commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

25 remaining items

dezren39 commented on Oct 28, 2026

dezren39 commented on Oct 28, 2026

dezren39 commented on Oct 28, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

id(web): emphasis/strong/strikethrough wrapping an image are silently dropped on save — mixed text+image spans split and leak entities #1407

Evidence (verified this run on main `37418e56`)