Repository navigation
fix(id): normalize unmarked text-run edge whitespace at save (#1420) - #1525
Conversation
Unmarked text runs were written verbatim on save but stripped on reopen by CommonMark reparse, and a whitespace-only paragraph was deleted outright. Save now trims an unmarked run's leading spaces at a line start (block start or after a hard_break) and its trailing spaces at a line end, so the first saved file is the fixpoint; a whitespace-only paragraph saves as an empty paragraph. Interior runs (word separators next to marks) and marked runs (#1418 mechanism) are untouched. Regression tests cover the five triage probe cases plus an interior-preservation guard.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efd1d6410d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for inline_json in para_content { | ||
| let inline_node = json_to_ast(arena, inline_json)?; | ||
| for (inline_idx, _inline_json) in para_content.iter().enumerate() { | ||
| let normalized = normalize_inline_child_json(para_content, inline_idx); |
There was a problem hiding this comment.
When a table cell contains multiple paragraphs (supported by content: "paragraph+" in pkgs/id/web/src/editor.ts), this path unwraps them into a single inline stream without adding separators. Normalizing each paragraph independently now removes whitespace that previously separated their words: paragraphs containing "one " and "two" previously saved as one two, but now save as onetwo, corrupting the cell's text. Normalize against the flattened cell boundaries, or preserve a separator between paragraphs.
Useful? React with 👍 / 👎.
Fixes #1420. Queue task 1487 (triage: task 1421, policy pinned there).
What
In
pkgs/id/src/web/markdown.rs, unmarked text runs were written verbatim on save, but CommonMark reparse strips edge whitespace (leading spaces per line, trailing spaces) and deletes a whitespace-only paragraph outright — the saved file and the reopened doc disagreed (non-fixpoint).Normalize at save (the triage-pinned policy), position-aware:
hard_break), scanning past whitespace-only siblings.hard_break).Deliberately untouched:
a+ em +cis a fixpoint); trimming them would fuse words. Covered by a guard test. mechanism; link/code edges stay as-is.Tests
cargo test --offline --lib --features web web::markdown(laptop): 91 passed, 0 failed, including 6 new regression tests for the five triage probe cases (leading spaces, trailing spaces, hard_break edges, table-cell padding, whitespace-only paragraph) plus the interior-preservation guard.Note: a fresh worktree lacks the gitignored
pkgs/id/web/dist/frontend build output, which thewebfeature's RustEmbed requires; a local stub was used for the laptop test run only (not committed). CI builds the real assets.Need help on this PR? Tag
@codesmith-botwith what you need.