Skip to content

Preserved branch: queue/1485-1418-edge-space-mark — decision needed (merge / cherry-pick / drop) #3534

Closed

Description

@dezren39

Preserved branch from the laptop worktree cleanup of 2026-11-01.

  • Branch: queue/1485-1418-edge-space-mark
  • Verified HEAD on origin: d99b6dde9c766bdad3f65316ff6c8d8374180c60
  • Provenance: this branch holds work that existed only in a local worktree on the laptop (unique commits and/or a rescue commit of uncommitted work: "rescue: preserve uncommitted work from worktree cleanup 2026-11-01"). It was pushed so the worktree could be removed without losing the work; the local tree and local branch are gone.
  • Decision needed: merge it, cherry-pick from it, or drop the branch. Nothing else references it; this issue is the record of what it holds.

Activity

  1. developing-today commented on Nov 1, 2026

    @developing-today
    Contributor
  2. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

    • Agent: queue worker (repo-worker-code), openchamber scheduled lane ec118cad
    • Session / ID: queue task 7336
    • Found via: queue claim (coverage pass triage)
    • Task: Preserved-branch decision for queue/1485-1418-edge-space-mark (HEAD d99b6dd): merge / cherry-pick / drop
    • Links: queue task 7336

    🤖 Agent note · done (triage)

    Findings (verified fresh against origin/main 8e76c6fa, 2026-11-03)

    1. The remote branch is gone: git ls-remote origin refs/heads/queue/1485-1418-edge-space-mark returns nothing. Per the issue, only the local worktree copy existed; nothing to preserve remotely ("do not delete the branch" is moot — already gone).
    2. The fix landed via PR fix(id): hoist delimiter-mark edge spaces touched by word chars on save (#1418) #1510: fix(id): hoist delimiter-mark edge spaces touched by word chars on save (#1418) — state MERGED 2026-10-28, merge commit dd9eb9795, which is an ancestor of current main. All PR checks were green at merge (incl. rustfmt-check, clippy, test shards).
    3. Landed code matches the preserved work: current main pkgs/id/src/web/markdown.rs contains hoist_delimiter_edge_spaces / hoist_one_edge with the #1418 comment — i.e. both preserved commits (fix ec2739dbe + rustfmt follow-up d99b6dde) are subsumed. (Exact SHAs differ due to squash/rebase at merge; content is present.)
    4. No competing owner: no open PR references this work; the bug issue id(web): a marked span starting or ending with a space loses its mark on reopen when a word character touches it — saved   form cannot reparse #1418 is CLOSED (2026-10-28, by the merge). A follow-up in the same area (id(web): edge whitespace in text runs is written on save but stripped on reopen — a whitespace-only paragraph is deleted outright #1420/fix(id): normalize unmarked text-run edge whitespace at save (#1420) #1525, 7b09ac0b) also already landed.

    Closing this issue as completed — the preserved branch served its purpose and its content is on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority/lowNice to have; do when convenient

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions