Skip to content

docs(facade): correct the claude-code continuity note — live attempt did not complete (#1412) - #1456

Merged
dezren39 merged 1 commit into
mainfrom
wave-c/1412-correction
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
wave-c/1412-correction

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown

Correction to PR #1455. The continuity comment in the claude-code parity section claimed two-turn context continuity was "live-verified against the running door (turn 2 recalled the turn-1 codeword)". That claim rested on a tool-output notification that proved to be fabricated; the real run's terminal output, the CLI's own on-disk transcript, and the door's session store all show the live attempt did NOT complete:

  • Door-spawned CLI children inherit the door's default sandbox egress proxy (hatch-egress-proxy), which does not resolve on the laptop → both turns answered "API Error: Can't reach the API server — check your internet or DNS (ENOTFOUND)".
  • A direct CLI probe (proxies unset) answered that the organization has disabled Claude subscription access for Claude Code.

This PR rewrites the comment to state what the evidence supports: the door's own stub suite (7/7 pass on the laptop) proves the delta mechanics; no live recall is claimed. The correction is also recorded on #1412 and #1152, and #1455's body has been edited to match. Comment-only change; the claude-code parity tests re-run green after the edit.

Refs #1412, #1152.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0aedc13f-e747-4ba5-9421-0585426037a8
Commits

Reviewing files that changed from the base of the PR and between 7f5edb1 and f824b34.

Files selected for processing: 1
  • packages/core/test/facade-parity.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T23:00:57.366200Z f824b34 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant