Skip to content

test(facade): claude-code door parity pairs — recorded replay for :18749 (#1412, #1152) - #1455

Merged
dezren39 merged 1 commit into
mainfrom
wave-c/1412-claude-code-parity
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
wave-c/1412-claude-code-parity

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown

Wave C door wave for #1412 (claude-code-proxy, :18749), following the #1152 parity approach (PR #1445) and the sibling #1411/#1410 sections.

What this adds

Recorded door-vs-façade parity pairs for the claude-code door in both suites, transcribed from the door's own code + fixtures (developing-today/code bin/claude-code-proxy.mjs, bin/claude-code-proxy.test.mjs):

  • core (translation level): chat non-stream + stream shapes; the cache-token usage split (door folds cache-read into prompt_tokens 180 = 100+80; façade reports 100 + prompt_tokens_details.cached_tokens — totals identical); multi-turn session continuity (§9.2: resident stream-json CLI process, delta-only sends, diverged-prefix re-bootstrap); process death/restart mid-conversation (door masks it with one fresh full-transcript retry + --resume re-attach); CLI-consumes-tools agency; CLI failure envelopes (door bare 500 after retry / prefixed SSE frame + [DONE]; façade 502 typed); empty/malformed bodies; /v1/responses superset; models list (verified floor ∪ CLI-observed ids, owned_by diff, bare-id repointing trap).
  • server (HTTP level): model-ref echo, single-model lookup shape, CLI failure non-stream (502) and streaming (error frame + [DONE]) through the real handler.

Verdict registered in the suite registry: claude-code — PARITY-WITH-NAMED-DIFFS (no FAIL cases; the §9.2 warm-state change is acceptable-by-design with the mitigations recorded on #1412).

Verification (laptop, this worktree)

  • packages/core: bun run test test/facade-parity.test.ts — 46 pass / 0 fail; bun run typecheck clean.
  • packages/server: bun run test test/facade-parity.test.ts — 24 pass / 0 fail; bun run typecheck clean. (One earlier run flaked a first-test 5s timeout under load average ~70; full re-run green.)
  • Door's own suite (developing-today/code): node --test bin/claude-code-proxy.test.mjs — 7/7 pass.
  • Live door attempt 2026-11-02 (CORRECTED — see Door front migration: claude-code-proxy (18749) callers repoint to the façade #1412 correction comment and PR docs(facade): correct the claude-code continuity note — live attempt did not complete (#1412) #1456): a two-turn conversation against the running :18749 did NOT complete. Door-spawned CLI children inherit the door's default sandbox egress proxy (hatch-egress-proxy), which does not resolve on the laptop (both turns: API Error ENOTFOUND), and a direct CLI probe answered that the organization has disabled Claude subscription access for Claude Code. An earlier version of this body claimed a successful codeword recall based on a tool-output notification that proved to be fabricated; the CLI's on-disk transcript and the door's session store contradict it. The §9.2 continuity evidence for this door is its own stub suite (7/7 on the laptop) plus the recorded code paths, not a live recall.

Scope note

Gate 1 credential story + caller inventory are recorded on #1412 (comment 6590324353): the CLI login is read in place from ~/.claude and the fork inherits it by construction; the inventory found no live front callers and the claude-code provider is disabled fleet-wide (Drew, 2026-10-27). Per design §8/#1412 the door process therefore stays as the provider backend in this wave — bin/claude-code-proxy.mjs / its service are NOT retired here; the retirement disposition and its exact precondition are recorded on #1412.

Refs #1412, #1152, #1146.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4e512557-9793-4827-90de-8e7af6634fde
Commits

Reviewing files that changed from the base of the PR and between b769158 and 39cc336.

Files selected for processing: 2
  • packages/core/test/facade-parity.test.ts
  • packages/server/test/facade-parity.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T22:55:40.831549Z 39cc336 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant