Skip to content

fix(kubescape): adopt the published summary metadata repair - #5420

Merged
devantler merged 2 commits into
mainfrom
codex/kubescape-summary-adoption-5419
Oct 27, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/kubescape-summary-adoption-5419

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Scan summaries can remain stuck after incomplete updates, preventing findings from refreshing.

What

Selects the reviewed, published repair while preserving existing scan records and rollout protections. Live verification remains tracked in #5419.

Part of #5419

Part of #5419. Pin the signed revision 8 image published from a56a2cf and keep the immutable-image contract aligned. Preserve payloads, storage and the single-writer rollout; live coherence and scan freshness remain deployment verification.
@devantler

devantler commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

This proposes the adoption step for the repair published by #5402. The image signature verifies against the exact main publisher identity, GitHub issuer and producer revision a56a2cf3b4a10ce5352f19e9a8e9da106373b00f. A wrong-source-revision negative control fails certificate verification. The digest-bound provenance chain was also checked against the signed index and pinned upstream source.

The immutable-image contract demonstrated RED against the old pin and GREEN against this pin. Both local and production KSail validation passed and explicitly evaluated the Kubescape base and HelmRelease. Unrelated OCI chart renders remain limited locally by an unavailable Docker credential helper; hosted validation is still required. Whitespace checks pass. The two-file self-review preserves the previous image as a rollback target, the retained store and the single-writer rollout.

Fresh repeated API reads reproduce stable summary version splits. A recent scoped scan-storage backup upload completed; this does not prove a full-platform restore. Production readiness remains held. After protected deployment, verify the running image, reconciliation receipt, LIST/GET identity/version agreement, a successful scanner update and current paired coverage. This draft claims no deployed repair and keeps #5419 and #4263 open for that evidence.

Part of #5419. The complete production render changes exactly the Kubescape HelmRelease fingerprint for the signed image pin. Approve that one reviewed entry and retain the closed authorization checks and negative controls.
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The two failed checks at the initial head had the same cause: the authorization ledger fingerprints the complete rendered HelmRelease, including its image pin. Commit 59d49862cad52d5219a5ad995dce1853ed705b9a updates exactly one reviewed entry:

helm.toolkit.fluxcd.io/v2|HelmRelease|kubescape|kubescape: 9c8af3c19edf7280701bae3bcd4ac1cd5e976e60170cacb027ea03fa2acbe973 → 726a055d85d504dbb77a9d713dbd898b469ce9a069530523fb89afe36d0ae2f2.

Its source delta is the signed revision 8 storage image pin already described above. Grant-bearing configuration and validator checks retain their existing scope. The actual production authorization validator and its complete targeted regression suite pass with the approved Kubernetes client. Current-head hosted validation now reports 37 successes and 12 intended skips. The frozen historical approval file is unchanged; this comment records the scoped approval evidence.

Review and live deployment verification remain required. The existing production recovery hold still applies.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a56a2cf and 59d4986.

Files selected for processing: 3
  • k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml
  • scripts/tests/test-kubescape-storage-hotfix.sh
  • scripts/validate-eks-ci-role-policy/approved-surface.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: CodeRabbit
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 3
Source excerpt: Resources under `k8s/bases/infrastructure/` are **component-folder-first**: a component's HelmRelease/HelmRepository and its own CRs live together in a folder named after the component — `controllers//` in the con...

CodeRabbit inference engine (AGENTS.md)

Files:

  • k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml
Source excerpt: **Put a change in the layer that matches its scope** — edit `k8s/bases/` when it should hold for **every consumer of that resource**; add an overlay `patches/` fragment only for a genuine per-consumer difference.

CodeRabbit inference engine (AGENTS.md)

Files:

  • k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml
Source excerpt: **Flux dependency order** — `bootstrap` → `flux-instance` → `infrastructure-controllers` → `infrastructure` → `apps`.

CodeRabbit inference engine (AGENTS.md)

Files:

  • k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml
Additional comments: 3
k8s/bases/infrastructure/controllers/kubescape/helm-release.yaml: 1

324-326: LGTM!

Also applies to: 328-328

scripts/tests/test-kubescape-storage-hotfix.sh: 1

14-14: LGTM!

scripts/validate-eks-ci-role-policy/approved-surface.txt: 1

71-71: LGTM!

Walkthrough

The Kubescape storage image pin changes from revision 7 to revision 8, including its digest. The accompanying comment describes revision 8’s conditional summary-row reconciliation and safeguards. The hotfix test’s expected image reference and the approved rendered-surface digest are updated to match.

Possibly related issues

  • Issue 5419 describes the published scan-storage summary repair and immutable image verification. This change updates the repair configuration’s image pin, but does not establish that deployment verification is complete.

Possibly related PRs

  • devantler-tech/platform#5262: Its Kubescape collector reads stored vulnerability summaries whose metadata is affected by the repair described for this image revision.
  • devantler-tech/platform#5268: Its security-progress component uses the collector and reporting path affected by the summary metadata repair.

Priority: Normal

Merge Risk: Minimal · up to 59d49

No merge-blocking issue is evidenced; deployment verification remains a follow-up.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adopting the published Kubescape summary metadata repair.
Description check Passed The description explains why the repair is needed and states that it preserves scan records and rollout protections.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness refreshed for 59d49862cad52d5219a5ad995dce1853ed705b9a against freshly fetched main 65e782731c2ff43a77b7fc3812406180f0dc99cd. The head is unchanged and forge-verified, all selected CI jobs are settled green, and GitHub reports CLEAN/MERGEABLE. The authenticated current-head CodeRabbit summary carries a finding-free recent-review verdict for this exact head; the canonical verdict helper returns GREEN. Complete comments, reviews, inline and thread reads contain no unresolved finding or maintainer request.

The immutable-image positive/negative signature controls, provenance chain, retained-data boundary, both rendered environments and authorization-entry validation remain the user-evaluation evidence. All readable required gates pass; native code-quality remains UNVERIFIED through the API and is left to protected enforcement. The full platform health helper passes. Deployment, repaired stored-summary comparison and coverage verification remain open in #5419; publication and merge alone cannot resolve the scanner findings.

@devantler
devantler marked this pull request as ready for review October 27, 2026 16:31
@devantler
devantler added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 8f0e7ed Oct 27, 2026
49 checks passed
@devantler
devantler deleted the codex/kubescape-summary-adoption-5419 branch October 27, 2026 18:39
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant