Skip to content

fix(kubescape): recover stuck vulnerability summaries - #5402

Merged
devantler merged 2 commits into
mainfrom
codex/kubescape-summary-repair-4263
Oct 27, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/kubescape-summary-repair-4263

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Vulnerability results can become stuck after a failed save, leaving the scanner unable to refresh the information used for security decisions.

What

Adds a repair that preserves existing scan records and rejects ambiguous changes. Deployment remains gated on signed publication and a separate verified rollout.

Part of #4263

Part of #4263. Reconcile an intact summary payload with lagging metadata before startup and on scanner retries. Preserve payloads and scan times, condition writes on the exact observed row, and refuse unsafe identities, paths or versions. Prove retention, retries, cancellation and failure boundaries with real SQLite and filesystem tests; run the full storage package with race detection before image publication.
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 6adbb79 and 82fbbbf.

Files selected for processing: 4
  • .github/workflows/publish-kubescape-storage-hotfix.yaml
  • docs/kubescape-result-coverage.md
  • k8s/bases/infrastructure/controllers/kubescape/storage-v0.0.297-summary-metadata-repair.patch
  • scripts/tests/test-kubescape-storage-hotfix.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T23:38:15.689673Z 82fbbbf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 82fbbbf903

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 82fbbbf9036b3ca9d1d1f9ac513b69c8aee01599: reproduced a payload save followed by metadata failure using the actual file-backed store and SQLite trigger, then observed retained-record reconciliation, idempotence and the next successful scanner update. Identity, corruption, concurrency and cancellation cases refuse unsafe repair. The full file-package race suite and binary build passed locally.

Hosted source verification run 40416583890 applied all three patches to the pinned upstream source, passed the complete race suite and built the Linux compatibility image without publication. The CI run passed its selected checks, including manifest validation and regressions. Codex's current-head review reports no findings; the full thread census is empty.

The forge reported CLEAN and mergeable at this head. Required-gate discovery confirms the reported gates; configured native code_quality is independently unreadable and remains UNVERIFIED by that helper, so the normal protected queue must enforce it. No override is used.

This delivers the tested producer repair and publisher. Production adoption remains a separate immutable image-pin change after signed publication, recovery evidence rebind and review. Neither deployment nor complete scan coverage is claimed here; #4263 remains open for live acceptance and remaining gaps.

@devantler
devantler marked this pull request as ready for review October 26, 2026 23:41
@devantler
devantler added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit a56a2cf Oct 27, 2026
49 checks passed
@devantler
devantler deleted the codex/kubescape-summary-repair-4263 branch October 27, 2026 01:25
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant