Skip to content

ci: re-pin the shared review engine and receive review events directly - #4710

Merged
shumkov merged 1 commit into
v4.2-devfrom
chore/repin-derived-engine
Sep 12, 2026
Merged

shumkov merged 1 commit into
v4.2-devfrom
chore/repin-derived-engine

Conversation

@shumkov

@shumkov shumkov commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

#4449 merged just before three central changes landed, so Platform's caller is the only one of the five still on the old shape. This brings it in line with rust-dashcore, Tenderdash, GroveDB and Dash Evo Tool.

What was done?

  • Re-pins the reusable workflow to a95eab4ec0938e9022edd0c82591d052408a38a5 (feat(workflow): read the engine pin from the caller's own workflow reference stale_prs_are_bad#9).
  • Removes with: engine_revision:. The engine commit used to be written twice with nothing verifying the two agreed; the callee now reads the pin out of this file's own uses: reference, from the branch GitHub ran the workflow from.
  • The policy workflow listens for pull_request_review directly, so .github/workflows/pr-review-signal.yml — a no-op job that existed only to wake it through workflow_run — is deleted. That path also never delivered a PR number for pull requests from forks.

The engine still refuses to run unless its commit is merged to the central default branch, and refuses to read policies unless that branch is protected by the required ruleset.

How Has This Been Tested?

The same caller shape is running green in preview on GroveDB and rust-dashcore. Writes remain disabled here: PR_REVIEW_AUTOMATION_ENABLED is not set, so runs only report what they would do.

Breaking Changes

None.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed an automated workflow that responded to pull request review changes.

Three central changes landed after #4449 merged: the policy workflow now
listens for pull_request_review itself (so the no-op signal workflow is
gone), and the engine commit lives only in the workflow reference, which the
callee reads. dashpay/stale_prs_are_bad#9 landed as
a95eab4ec0938e9022edd0c82591d052408a38a5.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.2.0 milestone Sep 12, 2026
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c09d70b4-1836-4ea9-acba-47b056038048

📥 Commits

Reviewing files that changed from the base of the PR and between 9a8c352 and 6f95c45.

📒 Files selected for processing (1)
  • .github/workflows/pr-review-signal.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/pr-review-signal.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request review signal workflow was deleted. The removed workflow listened for submitted, edited, and dismissed pull request reviews and ran a notification job.

Changes

Review Signal Workflow Removal

Layer / File(s) Summary
Remove review event workflow
.github/workflows/pr-review-signal.yml
Deletes the GitHub Actions workflow that triggered on pull_request_review events and echoed a policy refetch message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 6f95c

The reviewed workflow removal has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the two main changes: re-pinning the shared review engine and handling review events directly. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/repin-derived-engine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 11th in line, estimated start in ~5 h (commit 6f95c45)
Estimated review time once started: ~50 min (two-phase automated review; median of recent runs).

  • Request priority review — tick this box and the review moves to the front of the queue.

@shumkov
shumkov merged commit 9249ca1 into v4.2-dev Sep 12, 2026
20 of 21 checks passed
@shumkov
shumkov deleted the chore/repin-derived-engine branch September 12, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants