Repository navigation
ci: re-pin the shared review engine and receive review events directly - #4710
Conversation
Three central changes landed after #4449 merged: the policy workflow now listens for pull_request_review itself (so the no-op signal workflow is gone), and the engine commit lives only in the workflow reference, which the callee reads. dashpay/stale_prs_are_bad#9 landed as a95eab4ec0938e9022edd0c82591d052408a38a5. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request review signal workflow was deleted. The removed workflow listened for submitted, edited, and dismissed pull request reviews and ran a notification job. ChangesReview Signal Workflow Removal
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The reviewed workflow removal has no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 11th in line, estimated start in ~5 h (commit 6f95c45)
|
Issue being fixed or feature implemented
#4449 merged just before three central changes landed, so Platform's caller is the only one of the five still on the old shape. This brings it in line with rust-dashcore, Tenderdash, GroveDB and Dash Evo Tool.
What was done?
a95eab4ec0938e9022edd0c82591d052408a38a5(feat(workflow): read the engine pin from the caller's own workflow reference stale_prs_are_bad#9).with: engine_revision:. The engine commit used to be written twice with nothing verifying the two agreed; the callee now reads the pin out of this file's ownuses:reference, from the branch GitHub ran the workflow from.pull_request_reviewdirectly, so.github/workflows/pr-review-signal.yml— a no-op job that existed only to wake it throughworkflow_run— is deleted. That path also never delivered a PR number for pull requests from forks.The engine still refuses to run unless its commit is merged to the central default branch, and refuses to read policies unless that branch is protected by the required ruleset.
How Has This Been Tested?
The same caller shape is running green in preview on GroveDB and rust-dashcore. Writes remain disabled here:
PR_REVIEW_AUTOMATION_ENABLEDis not set, so runs only report what they would do.Breaking Changes
None.
🤖 Generated with Claude Code
Summary by CodeRabbit