Skip to content

fix(dashmate): disable ssl prompt for mainnet - #1114

Closed
pshenmic wants to merge 3 commits into
masterfrom
fix/dashmate-mainnet-ssl
Closed

pshenmic wants to merge 3 commits into
masterfrom
fix/dashmate-mainnet-ssl

Conversation

@pshenmic

@pshenmic pshenmic commented May 22, 2023 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

SSL prompting should be disabled for mainnet because it does not start platform services.

image

What was done?

Skip configureSSLCertificateTask in the setupRegularPresetTaskFactory.js

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v0.24.x milestone May 22, 2023
@pshenmic pshenmic self-assigned this May 22, 2023
@pshenmic
pshenmic requested review from antouhou and shumkov as code owners May 22, 2023 13:56
@pshenmic

Copy link
Copy Markdown
Contributor Author

Test results:

I checked out git branch and tried to setup a mainnet locally. The node did not prompt me for a SSL configuration and node has been configured sucessfully


     |\_/|     ╭───────────────────────────────────────────────╮
    / @ @ \    │           Hello! I'm your Dash mate!          │
   ( > º < )   │                                               │
    `>>x<<´    │ I will assist you with setting up a Dash node │
    /  O  \    │   on mainnet or testnet. I can also help you  │
               │   set up a development network on your local  │
               │                    system.                    │
               ╰───────────────────────────────────────────────╯

✔ System requirements
✔ Configuration preset
  › mainnet
✔ Node type
  › evolution masternode
✔ Register masternode
  › Operator Public key: b6ef1c4ac62919a13236ab1e2110dcdfc7470f8e4e81901a3672abb4993b418c85080476c6cc6aa42e6f9d27ea767c11
    Operator Private key: ******** - view with dashmate config get core.masternode.operator.privateKey

    Platform Node ID: 68a44dc6cc9736af944d4d05e0ac4b7242eeb729
    Platform Node key: ******** - view with dashmate config get platform.drive.tenderdash.node.key

    External IP: 92.127.179.225
    Core P2P port: 9999

    Platform P2P port: 26656
    Platform HTTP port: 443

› Node configuration completed successfully!

  You can now run dashmate start to start your node, followed by
  dashmate status for a node health status overview.

  Run dashmate --help or dashmate <command> --help for quick help on how
  to use dashmate to manage your node.

@pshenmic

Copy link
Copy Markdown
Contributor Author

Fixed in #1112

@pshenmic pshenmic closed this May 22, 2023
@pshenmic
pshenmic deleted the fix/dashmate-mainnet-ssl branch May 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant