Skip to content

Config: no author Role is named until its manifest exists, so no fix Run is dispatched to a missing Role (#675, record 0189) - #717

Merged
don-petry merged 9 commits into
mainfrom
config/author-role-null-675
Nov 10, 2026
Merged

don-petry merged 9 commits into
mainfrom
config/author-role-null-675

Conversation

@don-petry

@don-petry don-petry commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #675, "author_role is null until roles/dev-lead.json exists, so a fix Run is never dispatched to a missing role". It holds decision record 0189. The protected edits to config/defaults.json and sim/world.py are pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder.

What changes

What Now
config/defaults.json author_role: null. The Kernel decides no fix Run (kernel/decide.py's _wanted_run), so an item with an open blocking Finding or a failed check has outcome nothing and waits for a person. Before, each fix Run failed at harness.read with file_unreadable, on every pass up to the Run ceiling of 10 an item, and three such faults trip the automatic Pause
tools/check_authority.py Refuses a configured author_role or owner_role that is no Role's name as role/1 spells one (so none reaches outside roles/), or that has no file under roles/. The owner is always named; the author may be none. A named author Role is the authority table's, as before
tests/support.py, sim/world.py Take the author Role from the authority table. The simulator models the Factory once dev-lead exists, and the Kernel's fix path stays held with a Role in place. The live configuration defers each fix to a person until then, which a new test reading the real configuration holds

The record names when this changes back: the pull request that adds the author Role's manifest, waiting on roles/dev-lead.json, names it again.

Checks

  • tests/test_decide.py::test_the_configuration_names_no_author_role_until_its_manifest_exists: with the real configuration, an open blocking Finding and a failed check each give addressing with outcome nothing and no admission.
  • tests/test_tools.py::test_a_role_the_configuration_names_has_a_manifest.
  • Ten new mutants. At b5208ec, every mutant of config/defaults.json and tools/check_authority.py is killed. make checks and check_decisions are clean, apart from the record gap until 0185 to 0187 are on main. The simulator's and the Kernel's tests pass. CI runs the full verify.

Renumbered 0188 → 0189 in 0504b33, as the Factory Builder ordered the queue (the approval-step fix takes 0187, #713 0188).

Reviews

Reader Head Findings Disposition
Argon (gemini-4-argon-high) fb4e188 None —
Muse (muse-wonder-full-1.0) fb4e188 1 blocking: the record named a path not yet in the repo, and the context check refuses that; 1 major: a role name with ../ named a file outside roles/; 1 minor: the check allowed a null owner Role All fixed in d250b98, with tests and mutants
Astra (gpt-6-astra) d250b98 1 major: a name that only begins as a Role's passed Fixed in b5540a1, with a test and a mutant
Astra, second read b5540a1 1 major: no test accepted a validly named author Role Fixed in 53ee2be, with a test and a mutant
Astra, third read 53ee2be 1 major: no test told a manifest file from a directory of its name Fixed in daf849e, with a test and a mutant
Astra, fourth read daf849e 1 major: no test refused a name ending in a hyphen Fixed in b5208ec, with a test case and a mutant. No further read: four reads found only a missing test each

🤖 Generated with Claude Code

don-petry and others added 4 commits November 10, 2026 11:15
…Run is dispatched to a missing Role (#675)

config/defaults.json named the author Role dev-lead, and roles/ holds no dev-lead.json: each fix Run the Kernel
decided failed at harness.read with file_unreadable, on every pass up to the Run ceiling, and three such faults
trip the automatic Pause. It names none now, so an item needing a fix waits for a person with outcome nothing.

tools/check_authority.py refuses an author_role or owner_role that names no file under roles/; a named author
Role is the authority table's, as before, and none is allowed. tests/support.py and sim/world.py take the author
Role from the authority table, so the fix path and the simulated Factory are held with a Role in place, and a test
reads the real configuration. Decision NNNN records it and when it changes back. Pre-approved by the Maintainer
2026-11-08, ruled by the Factory Builder.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ways named, and the record's paths wait (#675, after Muse)

Muse: a name with ../ named a file outside roles/ and passed; each is now held to role/1's name. The owner Role
may not be none, as the schema and the Kernel already said; only the author may. The record names
roles/dev-lead.json as waiting, as a path not yet in the repo is named. Tests and two mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er Astra)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ber (#675)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 10, 2026 17:35
@don-petry don-petry added the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T17:35:08.030748Z
We couldn’t complete this review. Comment @codex review to try again.
223f467 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

don-petry and others added 3 commits November 10, 2026 11:35
…h its manifest, is accepted, and a test says so (#675, Astra's re-read)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… test says so (#675, Astra's last read)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t and a mutant say so (#675, Astra's fourth read)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lder ordered the queue

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry don-petry changed the title Config: no author Role is named until its manifest exists, so no fix Run is dispatched to a missing Role (#675, record 0188) Config: no author Role is named until its manifest exists, so no fix Run is dispatched to a missing Role (#675, record 0189) Nov 10, 2026
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Nov 10, 2026
Merged via the queue into main with commit 48687f2 Nov 10, 2026
31 checks passed
@don-petry
don-petry deleted the config/author-role-null-675 branch November 10, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

author_role is null until roles/dev-lead.json exists, so a fix Run is never dispatched to a missing role

1 participant