Repository navigation
Reconciliation: a pass that did not succeed and lists no record is read, after a second look (#709, record 0190) - #716
Conversation
…ad, after a second look (#709, record 0184) A cancelled or failed poller run uploads no `written`, and was never counted read: every later pass asked of it again, and each asking spent one of the 50 a pass reads. With 51 such runs in the 30-hour window, every pass since 2026-11-10T03:06Z was short and raised `reconciliation_unreadable`. Such a pass is now looked at once more in the same pass, after one wait of 5 seconds for them all. Listing none again, it is read with nothing recorded. A write it made is matched to no record, so `write_unmatched` is raised: reconciliation fails closed where it always did. A pass that succeeded and lists none is still short; a run not completed is still not looked at. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…hat holds null is short (#709, record 0184) The review of the second look found what the tests did not hold: - Both looks went through a list GitHub lets be held for 60 seconds, so a second look 5 seconds on could be the first's answer. Each look now sends Cache-Control: no-cache, as the records port does (decision 0036). - A `written` file holding `null` passed for a pass that lists none. It is no `written/1`: the pass is not read, not looked at twice, and what was read is short. - A completed run with no conclusion is not looked at twice and not read, as before the change: the second look is for a conclusion that says the pass did not succeed. - The tests now hold where the wait falls, that every pass that listed none is looked at again, that each record is dated as its own pass, that a second look that cannot be read does not end the ones after it, and that the wait is time.sleep unless another is handed. Ten new mutants, three retargeted; record 0184 has the rows. Co-Authored-By: Claude <noreply@anthropic.com>
… record 0190) The Factory Builder's number, given at enqueue: main holds 0184 to 0189. Co-Authored-By: Claude <noreply@anthropic.com>
… a pass (#709, record 0190) Co-Authored-By: Claude <noreply@anthropic.com>
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
|



Refs #709 ("Factory alerts"): the
reconciliation_unreadablealert, raised by every pass since 2026-11-10T03:06Z. It does not close the issue, which is the Controller's own.What was wrong
A cancelled or failed poller run uploads no
written.adapters/passes.writtentook "lists none" on such a run as "may be yet to", so it was never counted read: every later pass asked of it again, and each asking spent one of the 50 a pass reads (READS). The poller cancels its waiting run whenever another is queued, so the 30-hour window held 50 cancelled passes and 1 failed, against 180 that succeeded. From 51 unread on, every pass found more than 50 to read and was short, with nothing unread that could be read.What changes
writtenWAIT, as decision 0036's inadapters/records.py). Listing none again, it is read with nothing recorded, so no later pass asks of itCache-Control: no-cache), the first and the second. GitHub lets the answer be held for 60 seconds (decision 0036,trials/P-63.json), so a second look 5 seconds on could otherwise be the first's answerwritten/1, leaves the pass unread and what was read shortnullwritten/1: the pass is not read, not looked at twice, and what was read is short, whatever the pass concluded. Before, it passed for a pass that lists nonewrite_unmatchedis raised. Reconciliation fails closed where it always did. Should GitHub's list lag past both looks, a recorded write alarms as unmatched; it is never passed in silencemostbounds the first looks as before; the second looks are at most as many again, one request each unless a record has appeared, inside the step's 6 minutesThe record is
docs/decisions/0190-a-pass-that-did-not-succeed-and-lists-no-record-is-read-after-a-second-look.md, 0190 by the Factory Builder's number (main holds 0184 to 0189). It amends one row of 0112, for passes only. The branch carried it as 0184, a placeholder, through 4adf2de; 98b592d renames it and c29dcc2 merges main, and nothing else has changed since the readers' heads.Not here, each a follow-up for its own ruling:
adapters/applied.effectshas the same shape for a Run that failed and lists noapplied(read again at every pass, counted toward its 50). The ruling was on the passes, and the record says so.controller/__main__.py) does not hand its injectedsleepdown topasses.written, as it does not torecords.runson main. A test holds that the default istime.sleep.The step's budget: over the last 40 successful poller runs "Read and decide" took 134 s on average and 197 s at most, of its 360 s. This adds one wait of 5 s and at most 50 list requests to a pass, and passes get shorter once the backlog of 51 is read.
It ships in the Release after v0.1.4. At its first pass it clears the backlog of 51 in two passes: 50 first looks, one wait, 49 or 50 second looks.
Checks
tests/test_adapters.py:test_a_pass_that_did_not_succeed_and_lists_none_is_read_after_a_second_look,test_more_passes_that_list_none_than_a_pass_reads_are_read_whole_by_the_next,test_a_pass_still_running_is_not_looked_at_and_may_yet_record, andtest_a_write_by_a_pass_that_failed_and_recorded_nothing_is_unmatched_not_short, which runs the read throughcontroller.reconcile. Each was watched failing first; the assertions the review added are each held by a mutant that puts the old code back.adapters/passes.py, one inadapters/artifacts.py. Two old ones are gone with the rule they held ('a pass that lists none counts as read', 'a pass past its retention is read again').make checksis clean at c29dcc2, andtests.test_adapters,tests.test_reconcileandtests.test_controllerpass (231 tests). Every mutant ofadapters/passes.py(73) and ofadapters/artifacts.py(28) was applied at the desk at c29dcc2 against the tests it names, and each was killed. The desk's unfiltered run of 4adf2de, restarted after a reboot ended the first at 4,430, finished after the merge: 6,439 of 6,439 mutants killed; an earlier try could not finish its baseline inside 600 s on a loaded machine. The merge group runs every shard.Protected paths
adapters/,tests/andtools/are the verify Lens's inputs, andtools/mutants.pyanddocs/decisions/are reported paths: pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (the ruling of 2026-11-10 on #709).Reviews
nullrecord passed for "lists none"; per-pass dating and a later second look after one unreadable were unheld. Held, not threaded: the defaultsleep(follow-up above)write_unmatched. Measured above: the step's budget. Pre-existing and not changed here: awritten/1is not bound to its run and attempt; deleting a failed run's unreadablewrittenclears the short read🤖 Generated with Claude Code