Repository navigation
Kernel: a Lens review whose applied/1 is past retention on an open pull request is asked for again (#346) - #423
Conversation
…ll request is asked for again (#346) An applied/1 past the artifact retention recorded what can no longer be read, so the threads its Run opened cannot be joined to their Findings. The artifacts reader now tells it from one never uploaded; what the Lenses recorded names each such Run; the facts hold them as expired_reviews; and the Kernel asks that Lens's review of the current content again until one succeeds after it. A list it cannot read is facts_incomplete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and an object for EXPIRED A thread the expired Run left open is unreadable, and the Kernel defers on it before it asks for a review, so the re-ask runs only where no such thread is open: record 0096's limit and issue 420 say so, with a case. An adjudication answers no expired review, and of two expired Runs the later is the one a review must follow, each with a case and a mutant. EXPIRED is an object, never data a record could hold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…em is unreadable, and a running review answers nothing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…this one, each held Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6efac514a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…'s is read before a conflict or a Lens's failure admits a fix Run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le, so `done is not None` holds nothing; the mutant moves to what does Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Closes #346. Record 0096.
A Lens Run's
applied/1past the artifact retention (90 days) can no longer be read. Until now it was read as recording nothing, whole: record 0069's "Retention, the accepted miss". The Kernel now asks that Lens's review again.What changes
adapters/artifacts.pyreadtakes an optionalexpiredlist, which it tells when the artifact is past retention.appliedreturns the sentinelEXPIRED, whole, so a record gone with time is told apart from one never uploaded. A Run that succeeded and lists none (a deleted record) is still not wholeadapters/applied.pyexpired: True, reviewing nothing that can be heldadapters/facts.py,schemas/facts.schema.jsonfacts/1gains a requiredexpired_reviews: the run ids of the pull request's Lens Runs whose record is past retentionkernel/derive.pyreview_expired: a Lens whose Run has an expired record is asked to review the current content again (awaiting_review) until a review of exactly that content by that Lens succeeds after the expired Run.readable_expired: a list the Kernel cannot read isfacts_incomplete. A run id that names no Run of the item isrun_unreadabletests/test_decide.py::test_a_lens_review_past_retention_is_asked_for_againcovers each side of the rule. The adapter tests cover the expired record and the snapshottools/mutants.pytests/support.py,sim/world.py"expired_reviews": []What answers an expired review, and what does not:
The limit, and its follow-up
A fresh review does not close the expired Run's own open threads. With no record, their category cannot be joined, so a required Lens's open one is unreadable. The Kernel reads threads before it asks for a review, and an unreadable fact yields a deferral, never an action. So while such a thread is open, the item defers and the review is not asked until a person resolves it.
The re-ask works where the expired Run left no open thread, for example where a thread it recorded was deleted after the window. The rest is #420, "An expired Lens Run's open threads can be closed without a person, by that Lens's ruling carried out by the queue App", through record 0086's resolve act. Its story must also rule how such a thread is read.
Verify
make verifyon ee92d5d, an export of the branch merged with main, whose records now run to 0095: 1,359 tests OK (9 expected failures).Gates
Claude review with a security pass: request changes; one fix round.
max, notmin); case and mutant added.EXPIREDis an object, never data a record could hold; the docstrings are updated.Argon (split script, 3 parts): request changes.
run_unreadable, which also covers an empty id.max/minfinding was fixed in the Claude round.Muse: request changes.
run_unreadable; case and mutant added.Codex, on the merged branch (6efac51):
CI, on the merged branch (df57c67): the mutant "a review whose record is past retention supersedes" survived. Now that an expired record has its own branch, a Run that succeeded has a record, or is expired, or is not whole, so
done is not Noneheld nothing. Fixed in ee92d5d: the clause is gone, and the mutant now breaks the expired branch'sreviewed.Not changed here: the
contradictsguard, a Lens review that succeeded yet names a fault, also sits after those two branches. Read from the code, not tested.🤖 Generated with Claude Code