Skip to content

Kernel: a Lens review whose applied/1 is past retention on an open pull request is asked for again #346

Closed

Description

@don-petry

Part of the epic "Epic: slice 1, first approval. A Release on next reviews a pull request to this repo, and the machine user's approval stands" (#182).

Follows "Threads port: a Lens's recorded Finding comment missing from the threads read leaves it unreadable (#331, part 2)" (#338), by the Factory Builder's ruling of 2026-10-26 on it, and decision 0070.

Why. A Lens Run's applied/1 is an artifact, kept for the repository's artifact retention: 90 days, read from the repository's and the org's Actions settings on 2026-10-26. Past it, adapters/applied.py reads it as recording nothing, as an expired outcome is read (decision 0049). The stale rule only marks a pull request's attention; it never closes or holds one, so a pull request can stay open past the window. Then:

  • an open Lens thread has no category or severity to join, and a required Lens's open thread defers the pull request until a person resolves it;
  • a recorded thread deleted whole after the window is no longer missed by anything.

The rule. A completed Lens Run on a still-open pull request whose applied/1 is past retention is a review to ask for again: the Kernel admits a fresh review of the item's current content, and never reads the expired record as whole by default. A read that fails for any other reason stays unreadable.

Done when

  • The facts say which of a pull request's Lens Runs have an applied/1 past retention, and the Kernel admits a fresh review for such an item, with a boundary test.
  • The accepted miss decision 0070 names is re-pointed to it, and the rule has a mutant.

Activity

  1. added 4 commits that reference this issue on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions