Skip to content

Threads port: every review thread with who opened and resolved it; a Lens's is its own App's, and an outside reviewer's never defers (#191) - #289

Merged
don-petry merged 5 commits into
mainfrom
adapters/threads
Oct 21, 2026
Merged

don-petry merged 5 commits into
mainfrom
adapters/threads

Conversation

@don-petry

@don-petry don-petry commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #191. This is the last part of the facts port. It follows the working rulings on #191 (comment 6326441619) and the Maintainer's answers to them (comment 6327479372).

What it adds

  • adapters/threads.py reads every review thread in one GraphQL read, page by page.
    • Each thread is read with its id, whether it is resolved, who resolved it, and who opened it and when, from its first comment.
    • Each actor is told apart by timeline.Accounts, by account id and type, never by a name's spelling (decision 0005, L-57). No comment text is read.
    • A thread a person opened is human, with no severity.
    • A Lens's thread is one whose author is that Lens's own App. It has no category or severity until harness/ uploads the Finding records they are joined from (decision 0038). The join rows now say "waiting on harness/".
    • An outside reviewer's thread (CodeRabbit's, Codex's) is not a required Lens's thread, so it never defers. Only a required model Lens's own App's open thread defers (unreadable_thread).
    • The list counts as whole only when:
      • every counted thread was read, and none twice;
      • no cursor repeats;
      • no next page is named past the count.
    • Three cases are handled so as not to block the whole pull request:
      • A resolved thread with no resolver named (as when an App resolved it) is read with none, and the Kernel defers on that thread alone.
      • A thread whose first comment replies to another is refused, because its opener cannot be read.
      • A deleted account's thread refuses the snapshot. That limit is stated in the code.
  • adapters/facts.py puts threads and complete.threads in the snapshot from this read.
  • adapters/checks.py no longer counts threads.
  • Rows re-pointed: 0005, 0015, 0018, 0022, 0026, 0038 and adapters/AGENTS.md.

#191's Done-when

Gates

Gate Result
Claude review + security pass done; one fix round (0657068), then the Maintainer's narrowing (6f0a573)
AGY not required for this port (Argon reads Kernel, sim, CI and token-handling PRs)
Muse not run (Maintainer, 2026-10-20: Kernel/hook only)
Capped mutant run, by hand every adapters mutant killed (198 at c5441a8, plus the threads round)
Export verify (6f0a573) exit 0, 956 tests
tools/check_decisions.py in the checkout passes

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 5 commits October 21, 2026 16:02
…person's human (#191)

First cut; rows, mutants and the review still to come.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mutants (#191)

- 0005's thread accounts and the four Lens rows point at the threads test; 0038's join waits on harness/
- adapters/AGENTS.md: threads.py built, its two rules named
- mutants: the thread count gone from the checks; threads read, told, bounded and paged, each killed by hand

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ply is no opener (#191)

The review and security pass's fix round:

- a resolved thread with no resolver, as when an App resolved it, is read with none: the Kernel defers on it alone
- a thread whose first comment replies to another is refused: its opener cannot be read
- the machine user's thread has no category, tested; the deleted-account and paging limits stated
- the checks' next-page mutant no longer names the removed thread count
- 0005's row says a thread's shape is not held yet by a trial

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ewer's never defers (#191)

The Maintainer's narrowing on #191: CodeRabbit's, Codex's and any outside reviewer's threads are no required
Lens's; only an open thread by a required model Lens's own App with no category defers, until harness/'s join.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner October 21, 2026 22:14
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-21T22:14:30.960356Z
We couldn’t complete this review. Comment @codex review to try again.
6f0a573 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: combsmith/software-factory/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6c52f6b6-d74c-4860-a993-9d21b20f9835
📥 Commits

Reviewing files that changed from the base of the PR and between b4bc1dc and 6f0a573.

📒 Files selected for processing: 12
  • adapters/AGENTS.md
  • adapters/checks.py
  • adapters/facts.py
  • adapters/threads.py
  • docs/decisions/0005-each-role-writes-through-its-own-app.md
  • docs/decisions/0015-a-lens-is-read-from-its-own-app-and-only-what-gates-holds-a-merge.md
  • docs/decisions/0018-a-lens-is-read-from-its-own-app-and-workflow-and-only-what-gates-holds-a-merge.md
  • docs/decisions/0022-a-lens-is-read-from-its-own-app-and-workflow-its-job-judges-every-job-it-waits-on-and-only-what-gates-holds-a-merge.md
  • docs/decisions/0026-a-lens-is-read-from-its-own-app-and-workflow-its-job-judges-every-job-it-waits-on-and-only-what-gates-holds-a-merge.md
  • docs/decisions/0038-a-result-asks-and-names-no-one-and-apply-writes-the-finding-it-posted.md
  • tests/test_adapters.py
  • tools/mutants.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit b3a3fe3 Oct 21, 2026
19 checks passed
@don-petry
don-petry deleted the adapters/threads branch October 21, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Facts port: one snapshot of a pull request from GitHub, with its completeness flags

1 participant