You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Facts port: the contract test replays every recorded fixture against the fake #283
Part of the epic "Epic: slice 1, first approval. A Release on next reviews a pull request to this repo, and the machine user's approval stands".
Why. One Done-when bullet of "Facts port: one snapshot of a pull request from GitHub, with its completeness flags" (#191) was not met as written: "a contract test replays every trials/ fixture through the port and compares its answer with the fake GitHub's for the same exchange". The contract test that landed (#278, tests/test_adapters.py::test_the_port_reads_each_grounded_rule_as_the_fake_assumes_it) does three things:
it reads each grounded rule the port reads from the fixture that grounds it;
it names every other grounded rule as not read yet;
it never runs the fake.
Done when
For each fixture in trials/ holding an exchange the port asks, the port's reading of the recorded answer and the fake GitHub's answer to the same request (sim/) are compared, and a difference fails the test.
A response the fixture shows GitHub rejecting fails the test (FR-56).
The grounded rules the test now names as not read are each read, or say why none can be.
Activity
Contract test: a 200 with errors is no answer to any GraphQL port; th…
Facts port: the contract test reads every grounded rule from its fixt…