Skip to content

dev-lead: deferred review findings #616

Closed as not planned
Closed as not planned

Description

@don-petry

Tracking issue for review findings that are valid but out of scope for their originating PRs.

Findings should be evaluated in petry-projects/.github per the org's standards-sync workflow.

Activity

  1. don-petry commented on Oct 11, 2026

    @don-petry
    CollaboratorAuthor

    CodeAnt: pull_requests[0] race condition in concurrency group
    #594 (comment)

    Valid concern: When one commit belongs to multiple PRs, using pull_requests[0] as the concurrency group key can cause one PR's run to cancel another's readiness evaluation. However, this is part of the org-canonical workflow from petry-projects/.github and the behavior is intentional per issue #1126 in the org standards. Should be addressed upstream.

  2. don-petry commented on Oct 11, 2026

    @don-petry
    CollaboratorAuthor

    Cubic: Local behavior drift from adding concurrency to stub
    #594 (comment)

    Valid concern: Adding behavior only to this stub creates drift from the canonical source. However, this PR is a standards-sync that brings the stub into byte-identical alignment with the canonical org workflow (closes #591). The concurrency block originates from petry-projects/.github, not created locally here.

  3. don-petry commented on Oct 21, 2026

    @don-petry
    CollaboratorAuthor

    Closing after the 2026-10-21 backlog triage.

    Why: pull_requests[0] concurrency is intentional per .github#1126; stub byte-identical
    Evidence: combsmith/.github#1126

    Reopen if this still reproduces on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions