Skip to content

Compliance: stub-surface-drift-pr-auto-review.yml-concurrency #591

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: warning
Check: stub-surface-drift-pr-auto-review.yml-concurrency

Detail

The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Copy the relevant workflow template from standards/workflows/ verbatim — do not generate from scratch:

gh api repos/petry-projects/.github/contents/standards/workflows/<template>.yml --jq '.content' | base64 -d > .github/workflows/<template>.yml

Available templates: agent-shield.yml, dev-lead.yml, dependabot-automerge.yml, dependabot-rebase.yml, dependency-audit.yml, feature-ideation.yml


This issue was automatically created by the weekly compliance audit.

Activity

  1. added
    compliance-auditAutomated compliance audit finding
    dev-leadFor dev-lead agent pickup
    compliance-findingMachine-owned: created and auto-closed by the compliance audit. Do not hand-apply.
    on Sep 18, 2026
  2. don-petry commented on Sep 18, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: implementation deferred — automation PR queue is full

    No pull request was opened for issue #591. The org-wide
    open-automation-PR queue is currently at its signed-off cap (see
    standards/pr-limits.json in petry-projects/.github).

    This issue stays labeled dev-lead and will be re-attempted automatically once
    the queue drains — no action is required.

  3. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 20, 2026
  4. don-petry commented on Sep 20, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #591 — Compliance: stub-surface-drift-pr-auto-review.yml-concurrency

    Scope

    Re-sync the centrally-owned concurrency: block of the pr-auto-review.yml thin caller stub from the canonical standards/workflows/pr-auto-review.yml; the local stub is currently missing the block entirely.

    Root cause (from diff of local vs canonical)

    The local .github/workflows/pr-auto-review.yml is byte-identical to the canonical template except it lacks the concurrency: block (and its explanatory comment) that belongs between permissions: {} and jobs:. Repo-adjustable surfaces (workflow_run.workflows: ["CI"], GH_PAT_DON_PETRY secrets fallback) already match canonical and will be preserved. No with: input forwarding is involved, so the channel-skew guardrail (#1052) does not apply.

    Implementation Checklist

    • Insert the canonical concurrency: block (verbatim, incl. its comment) into .github/workflows/pr-auto-review.yml between permissions: {} and jobs:
    • Confirm diff against the freshly-fetched canonical shows no drift

    Tests to Write

    • None — pure CI-workflow config change with no testable JS logic (Phase 2 TDD exception: configuration change, no observable behavioral change). Verification is a diff against the canonical template + repo lint.

    Test Command

    npm test (repo suite, unaffected) — plus diff vs canonical and bash .dev-lead/scripts/dev-lead-lint.sh

  5. don-petry commented on Sep 20, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet; the automation posts the authoritative
    completion record (with PR number + head SHA) after the push. Treat the notes
    below as intent, not delivered results.

    Plan Execution (intended)

    • Diffed local .github/workflows/pr-auto-review.yml against canonical standards/workflows/pr-auto-review.yml — only drift was the missing concurrency: block (and its comment) between permissions: {} and jobs:.
    • Re-synced the block verbatim from the canonical template; repo-adjustable surfaces (workflow_run.workflows: ["CI"], GH_PAT_DON_PETRY secrets fallback) were already canonical and were preserved.
    • No with: input forwarding involved, so the channel-skew guardrail (#1052) does not apply.

    Local check output (provisional — not the pushed run)

    dev-lead-lint: all checks passed
    npm run check: exit 0 (22 pre-existing warnings, unrelated)
    npm test: 17 suites / 465 tests passed
    diff vs freshly-fetched canonical: VERBATIM MATCH — no drift remaining
    

    Files touched (this workspace, not yet pushed)

    • .github/workflows/pr-auto-review.yml: inserted the centrally-owned concurrency: block (group keyed per-PR for check_suite/workflow_run with cancel-in-progress, unique-per-run fallback otherwise), re-syncing the stub with the canonical standard.

    Notes

    No test code added — pure CI-workflow config re-sync with no observable behavioral change to testable JS logic (Phase 2 TDD exception). Verification is diff against the canonical + repo lint.

  6. don-petry commented on Sep 20, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete — PR #594

    The implementation for issue #591 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  7. don-petry commented on Sep 25, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-09-25)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

  8. don-petry commented on Oct 2, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-10-02)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

  9. don-petry commented on Oct 9, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-10-09)

    This finding is still open.

    Detail: The pr-auto-review.yml caller stub's concurrency: surface has drifted from the canonical standards/workflows/pr-auto-review.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync concurrency: from standards/workflows/pr-auto-review.yml.

    Standard: standards/ci-standards.md#centralization-tiers

  10. added a commit that references this issue on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingcompliance-findingMachine-owned: created and auto-closed by the compliance audit. Do not hand-apply.dev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions