Skip to content

feat: implement issue #469 — [Fleet Monitor] petry-projects/broodly — .github/workflows/dependabot-automerge.yml - #470

Merged
don-petry merged 3 commits into
mainfrom
dev-lead/issue-469-20260805-0922
Aug 5, 2026
Merged

don-petry merged 3 commits into
mainfrom
dev-lead/issue-469-20260805-0922

Conversation

@don-petry

@don-petry don-petry commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

User description

Closes #469

Implemented by dev-lead agent. Please review.


CodeAnt-AI Description

Prevent corrupted GitHub Actions workflows from reaching the main branch

What Changed

  • CI now checks every GitHub Actions workflow for valid YAML, a trigger, and at least one job
  • Truncated or comment-only workflow files are rejected with a clear failure message
  • The integrity check includes a test proving corrupted workflow stubs are detected

Impact

✅ Fewer workflow startup failures
✅ Corrupted workflows blocked before merge
✅ Clearer CI validation errors

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Tests
    • Added automated validation for GitHub Actions workflow files.
    • Workflows are checked for valid YAML, required triggers, and non-empty job definitions.
    • CI now runs the workflow integrity checks automatically.

… .github/workflows/dependabot-automerge.yml
@don-petry
don-petry requested a review from a team as a code owner August 5, 2026 09:31
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai

codeant-ai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 5348fd4 Aug 05, 2026 · 09:31 09:33

@qodo-code-review

Copy link
Copy Markdown

ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing

@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Aug 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Bash script, tests/scripts/workflow-integrity.test.sh, to verify that all GitHub Actions workflow files are structurally valid and contain the required on: and jobs: blocks. The review feedback suggests guarding the temporary directory cleanup inside the trap command to prevent unbound-variable aborts under set -euo pipefail.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #470
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-08-05T10:02:14Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-08-05T10:02:14Z

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:32
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add CI guard to reject structurally invalid GitHub Actions workflows

🐞 Bug fix 🧪 Tests ⚙️ Configuration changes 🕐 20-40 Minutes

Grey Divider

AI Description

• Add a CI test to fail fast if any workflow YAML is truncated/corrupted
• Validate workflows have an on: trigger and a non-empty jobs: mapping
• Add a regression fixture proving comment-only workflow stubs are rejected
Diagram

graph TD
  A["GitHub Actions CI"] --> B["workflow-integrity.test.sh"] --> C{PyYAML available?}
  C -->|"yes"| D["python3 yaml.safe_load"] --> F["Validate .github/workflows/*.yml"] --> G["Pass/Fail CI"]
  C -->|"no"| E["grep for on:/jobs:"] --> F
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use actionlint for full workflow linting
  • ➕ Catches many more issues than structural checks (invalid expressions, runner labels, action inputs, etc.)
  • ➕ Commonly used and purpose-built for GitHub Actions
  • ➖ Adds a new dependency/binary to CI (installation, pinning, caching)
  • ➖ May introduce noise/false positives requiring configuration
2. Yamllint + schema validation
  • ➕ Standard YAML style + structure checks; configurable rule set
  • ➕ Can enforce formatting consistency across workflow files
  • ➖ Schema validation for GitHub Actions is imperfect; may still miss key semantic errors
  • ➖ More configuration overhead than the current targeted guard
3. Pre-commit / local git hook to block truncated workflows
  • ➕ Prevents bad commits earlier than CI
  • ➕ No CI time cost on every run
  • ➖ Not enforceable for all contributors unless also enforced in CI
  • ➖ Does not protect against corruption introduced by automation without local hooks

Recommendation: Keep the current approach: it directly targets the failure mode from #469 (comment-only/truncated workflow files) with minimal new dependencies and a clear regression fixture. Consider layering actionlint later if you want broader workflow correctness coverage beyond presence of on/jobs.

Files changed (2) +134 / -0

Tests (1) +132 / -0
workflow-integrity.test.shAdd workflow YAML structural validator with regression fixture +132/-0

Add workflow YAML structural validator with regression fixture

• Introduces a bash test that validates each .github/workflows YAML file parses as a mapping, contains an 'on' trigger (accounting for YAML 1.1 boolean parsing), and has a non-empty 'jobs' mapping. Includes a negative fixture to ensure comment-only/truncated workflow stubs are rejected, with a grep-based fallback when PyYAML is unavailable.

tests/scripts/workflow-integrity.test.sh

Other (1) +2 / -0
ci.ymlRun workflow integrity test in CI +2/-0

Run workflow integrity test in CI

• Adds a new CI step that runs the workflow integrity test script. This ensures invalid/truncated workflow YAML files fail CI before merging.

.github/workflows/ci.yml

@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d574064a-68f1-4a21-8071-99bc3e0981ec

📥 Commits

Reviewing files that changed from the base of the PR and between 5348fd4 and 935694a.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • tests/scripts/workflow-integrity.test.sh
📝 Walkthrough

Walkthrough

The PR adds a Bash test that validates all GitHub Actions workflow files. It checks YAML structure, required on and jobs keys, truncated input rejection, per-file results, and aggregate status. CI runs the test in the shell-tests job.

Changes

Workflow integrity validation

Layer / File(s) Summary
Workflow validator
tests/scripts/workflow-integrity.test.sh
The script validates workflow YAML with PyYAML or a key-based fallback. It requires on and non-empty jobs mappings.
Workflow discovery and CI execution
.github/workflows/ci.yml, tests/scripts/workflow-integrity.test.sh
The script discovers all workflow files, reports results, returns an aggregate status, and runs from the shell-tests job.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant shell-tests
  participant workflow-integrity.test.sh
  participant GitHubActionsWorkflows
  shell-tests->>workflow-integrity.test.sh: Run validation script
  workflow-integrity.test.sh->>GitHubActionsWorkflows: Discover workflow files
  GitHubActionsWorkflows-->>workflow-integrity.test.sh: Return workflow paths
  workflow-integrity.test.sh-->>shell-tests: Return aggregate test status
Loading

Possibly related PRs

Suggested reviewers: donpetry-bot

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The changes do not modify or diagnose .github/workflows/dependabot-automerge.yml, so they do not demonstrate resolution of issue #469. Modify .github/workflows/dependabot-automerge.yml or provide a targeted fix and evidence that its reported reliability issue is resolved.
Out of Scope Changes check ⚠️ Warning The repository-wide workflow-integrity test and CI integration are not tied to the specific workflow reliability issue in #469. Move the generic integrity test to a separate change or document its direct relationship to #469, then implement the target workflow fix.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references the linked issue and target workflow, but it does not describe the added workflow-integrity test as the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-469-20260805-0922

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@don-petry
don-petry disabled auto-merge August 5, 2026 09:33
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:35
@don-petry
don-petry disabled auto-merge August 5, 2026 09:36
@qodo-code-review

qodo-code-review Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (1)

Grey Divider


Remediation recommended

1. Fallback validation too weak ✓ Resolved 🐞 Bug ☼ Reliability
Description
When PyYAML is unavailable, validate_workflow_file() only greps for literal top-level "on:" and
"jobs:" lines, so unparseable YAML (or an empty jobs mapping) can still pass despite the script
claiming to require YAML parseability and non-empty jobs. Because ci.yml doesn’t install PyYAML
before running this test, the effective strictness depends on the runner image and can silently
degrade to the weaker check.
Code

tests/scripts/workflow-integrity.test.sh[R70-73]

+    local reason=""
+    if ! grep -Eq "^[\"']?on[\"']?:" "$path"; then
+      reason="missing 'on:' trigger block"
+    elif ! grep -Eq "^jobs:" "$path"; then
Relevance

●●● Strong

Team favors hermetic, deterministic CI/tests; missing PyYAML causing weaker validation likely fixed.

PR-#327
PR-#434

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The script explicitly defines validity as “parses as a YAML mapping … and has a non-empty jobs:
mapping,” but the fallback path only checks for the presence of on: and jobs: text. CI runs the
script as-is without installing PyYAML, so the fallback can be the path executed depending on the
environment.

tests/scripts/workflow-integrity.test.sh[13-15]
tests/scripts/workflow-integrity.test.sh[66-81]
.github/workflows/ci.yml[165-176]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The workflow integrity test degrades to a grep-only check when PyYAML is missing, which can allow malformed workflows to pass even though the script’s header says it enforces YAML parseability and a non-empty `jobs:` mapping.

## Issue Context
The CI workflow invokes this script without ensuring PyYAML is installed, so the strict path is not guaranteed.

## Fix Focus Areas
- .github/workflows/ci.yml[165-176]
- tests/scripts/workflow-integrity.test.sh[27-81]

## Proposed fix
1) In `.github/workflows/ci.yml` (shell-tests job), install a pinned PyYAML version before running the integrity test, e.g.:
  - `python3 -m pip install --disable-pip-version-check --no-cache-dir PyYAML==<pinned>`
2) Optionally, simplify `workflow-integrity.test.sh` by removing (or tightening) the grep fallback once PyYAML is guaranteed, so the test behavior is deterministic and matches the documented contract (parseable YAML + non-empty jobs mapping).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. workflow-integrity.test.sh multiple assertions 📜 Skill insight ✧ Quality
Description
The new tests/scripts/workflow-integrity.test.sh mixes multiple independent assertions (a negative
fixture rejection check and a per-workflow validation loop) and uses if/else branching to drive
test outcomes. This violates the repository’s atomic-test and no-conditional-logic-in-tests
requirements and makes failures harder to localize.
Code

tests/scripts/workflow-integrity.test.sh[R97-103]

+if validate_workflow_file "$_bad_fixture" >/dev/null 2>&1; then
+  echo "not ok - validator accepted a truncated comment-only workflow"
+  fail=1
+else
+  echo "ok - validator rejects a truncated comment-only workflow"
+  pass_count=$((pass_count + 1))
+fi
Relevance

●● Moderate

Repo’s shell tests commonly use if/else and multiple checks; “no-conditional-tests” rule precedent
unclear.

PR-#374
PR-#434

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Compliance rule 2239144 requires each test to be atomic (one assertion), but the added script
performs at least two distinct checks in the same file: it asserts the validator rejects a truncated
workflow and separately iterates over real workflows to assert they are valid. Compliance rule
2239155 forbids conditional branching in test bodies, yet the script includes `if ...; then ... else
... fi` blocks to perform assertions and handle results, creating multiple execution paths within
the test.

tests/scripts/workflow-integrity.test.sh[84-103]
tests/scripts/workflow-integrity.test.sh[105-124]
tests/scripts/workflow-integrity.test.sh[97-103]
tests/scripts/workflow-integrity.test.sh[110-113]
tests/scripts/workflow-integrity.test.sh[117-123]
Skill: bmad-testarch-automate
Skill: bmad-testarch-test-review

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`tests/scripts/workflow-integrity.test.sh` currently violates test-design compliance rules by (1) combining multiple independent assertions in a single test script (negative-fixture rejection plus per-workflow validation) and (2) using `if/else` branching in the test body, which creates multiple execution paths.

## Issue Context
This script is invoked from CI as a “test” step, so it must follow the repository’s test design rules (atomic tests and no conditional branching in test bodies). Where branching is currently used to express pass/fail logic, the same checks should be written without explicit `if/else`, e.g., via deterministic command chaining (`&&`/`||`) and/or helper functions that return appropriate exit codes.

## Fix Focus Areas
- tests/scripts/workflow-integrity.test.sh[35-82]
- tests/scripts/workflow-integrity.test.sh[84-124]
- tests/scripts/workflow-integrity.test.sh[97-103]
- tests/scripts/workflow-integrity.test.sh[110-113]
- tests/scripts/workflow-integrity.test.sh[115-124]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Informational

3. Fallback regex brittle ✓ Resolved 🐞 Bug ⚙ Maintainability
Description
The grep fallback requires on: to start at column 0 and requires jobs: to be exactly unquoted at
column 0, so YAML-valid variants like leading whitespace or 'jobs': will be flagged as invalid
when the fallback path is used. This makes the new guard fragile to harmless formatting/key-quoting
changes.
Code

tests/scripts/workflow-integrity.test.sh[R71-74]

+    if ! grep -Eq "^[\"']?on[\"']?:" "$path"; then
+      reason="missing 'on:' trigger block"
+    elif ! grep -Eq "^jobs:" "$path"; then
+      reason="missing 'jobs:' block"
Relevance

●●● Strong

Regex brittleness is a low-risk robustness tweak; similar “avoid false positives” test hardening
accepted.

PR-#434

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The fallback patterns are explicitly anchored to the beginning of the line and the jobs check only
matches jobs: (not quoted/indented), which is a strict subset of YAML-valid key formatting.

tests/scripts/workflow-integrity.test.sh[71-74]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The grep-based fallback is stricter than necessary: it only matches `on:` and `jobs:` when they appear unindented and (for jobs) unquoted.

## Issue Context
This only affects the non-PyYAML fallback path, but it can still cause spurious CI failures if someone formats root keys differently.

## Fix Focus Areas
- tests/scripts/workflow-integrity.test.sh[66-75]

## Proposed fix
Update the fallback regexes to accept optional leading whitespace and optional quotes for both keys, e.g.:
- `^[[:space:]]*["']?on["']?[[:space:]]*:`
- `^[[:space:]]*["']?jobs["']?[[:space:]]*:`
This reduces false failures without changing the intent of detecting truncated comment-only workflows.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context used
✅ Compliance rules (platform): 124 rules
✅ Skills: 5 invoked
  bmad-testarch-ci
  bmad-testarch-test-review
  bmad-testarch-atdd
  bmad-testarch-framework
  bmad-testarch-automate

To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #470
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-08-05T10:07:44Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-08-05T10:07:44Z

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:37
@don-petry
don-petry disabled auto-merge August 5, 2026 09:38
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- Quality Gate passed; 0 new issues found
- 0 security hotspots identified
- No Tier 1 blockers present
Files changed: None
Skipped (already passing): Quality metrics
```

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:39

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/scripts/workflow-integrity.test.sh`:
- Around line 54-56: Update the workflow validation logic around the PyYAML
check and its fallback so both branches require an exact `on` trigger key and a
non-empty `jobs` mapping. Prevent YAML 1.1 aliases such as `true` or `yes` from
satisfying the trigger check, and ensure the fallback handles quoted `jobs` keys
without accepting malformed workflows; if exact validation cannot be implemented
safely, fail closed.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: db577b15-1672-4e48-b24c-aacfedb8e15c

📥 Commits

Reviewing files that changed from the base of the PR and between ff2c20f and 5348fd4.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • tests/scripts/workflow-integrity.test.sh

@don-petry
don-petry disabled auto-merge August 5, 2026 09:40
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:47
@don-petry
don-petry disabled auto-merge August 5, 2026 09:47
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) August 5, 2026 09:50

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: 935694a9859d894500481242fdedef02fb30d5c8
Review mode: triage-approved (single reviewer)

Summary

Adds a CI workflow-integrity guard (tests/scripts/workflow-integrity.test.sh, +2 steps in ci.yml) that validates every .github/workflows/*.yml parses as a YAML mapping with an 'on:' trigger and a non-empty 'jobs:' mapping. This directly prevents the truncated/comment-only workflow corruption that caused the startup failures flagged by Fleet Monitor issue #469. Includes a negative-assertion fixture proving the validator rejects a truncated stub, a PyYAML strict path (pinned 6.0.2) and a grep-based fallback.

Linked issue analysis

Closes #469 ([Fleet Monitor] dependabot-automerge.yml, 15.6% failure rate from GitHub startup failures). Root cause was a workflow file truncated to its comment header (no 'on:'/'jobs:'), which GitHub records as failed runs. The new CI guard blocks any structurally invalid workflow from merging, substantively addressing the issue at its source rather than patching the single file.

Findings

  • No blocking findings.
  • Security: no secrets or credentials introduced; checkout uses persist-credentials: false; PyYAML is version-pinned (6.0.2). Gitleaks, CodeQL, and SonarCloud quality gate all pass. (The run_secret_scanning MCP tool was unavailable in this environment; the gitleaks CI check is green.)
  • Correctness: validator correctly handles the YAML 1.1 'on'-as-boolean quirk via a raw-text regex; negative fixture prevents a trivially-passing test; set -euo pipefail with guarded command substitutions is sound.
  • Minor (non-blocking): PyYAML is pinned by version but not by hash; the no-PyYAML grep fallback is looser than the strict path (accepts indented/empty 'jobs:'), but CI installs PyYAML so the strict path always runs there. Prior bot review threads (gemini, codeant, qodo, coderabbit) on these points are all resolved/outdated after fixes.
  • All 6 review threads resolved; no unanswered human-reviewer questions.

CI status

All required checks green: Shell Tests, TypeScript, Go, CodeQL (actions/go/js-ts), SonarCloud quality gate, gitleaks secret scan, AgentShield, dependency-audit (npm/pnpm/govulncheck). Skipped checks (cargo/pip audit, Push API Image, dependabot) are ecosystem-conditional and expected. mergeable=MERGEABLE; blocked only on review decision.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 061097a into main Aug 5, 2026
26 checks passed
@don-petry
don-petry deleted the dev-lead/issue-469-20260805-0922 branch August 5, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/broodly — .github/workflows/dependabot-automerge.yml

2 participants