Repository navigation
feat: implement issue #320 — Compliance: check-suite-prefs-unreadable - #327
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 8 minutes and 52 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request corrects the GitHub REST API endpoint for check-suite preferences from singular to plural (check-suites/preferences) in scripts/apply-repo-settings.sh and introduces integration tests in tests/integration/apply-repo-settings.bats. The review feedback correctly identifies that although the test header claims to stub both gh and jq, only gh is actually mocked. To ensure the integration tests are fully hermetic and do not fail in environments lacking jq, a mock for jq should be added as suggested.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 7e4567e700c4f841fb477eef085173bbbc0eb13c
Review mode: triage-approved (single reviewer)
Summary
Corrects the GitHub REST API endpoint for check-suite preferences from the non-existent singular path (check-suite/preferences) to the correct plural path (check-suites/preferences) in scripts/apply-repo-settings.sh, and adds hermetic bats integration tests that stub gh and jq to assert the plural endpoint is used and dry-run issues no PATCH. Diff is +64/-2 across 2 files.
Linked issue analysis
Closes #320 (Compliance: check-suite-prefs-unreadable). The compliance audit could not evaluate check-suite preferences; its remediation is to run scripts/apply-repo-settings.sh. That script targeted a wrong (singular) endpoint, so the remediation could not succeed. This PR fixes the endpoint so the remediation works and adds regression tests guarding the correct path. Substantively addressed.
Findings
No issues. The endpoint correction matches GitHub's documented PATCH /repos/{owner}/{repo}/check-suites/preferences. Tests are well-structured (positive, negative, and dry-run cases) and hermetic. gemini-code-assist's informational note about a missing jq mock is already resolved — a jq mock is present in the test setup. No CHANGES_REQUESTED reviews and no unresolved threads. MCP secret-scan tool was not permitted in this environment (noted, not failed); the gitleaks CI check passed.
CI status
All checks green. Successes include CI (TypeScript, Go, Secret scan/gitleaks), CodeQL (actions/go/javascript-typescript), SonarCloud (Quality Gate passed, 0 new issues), AgentShield, and dependency-audit. Remaining checks are SKIPPED (e.g. dependabot-automerge, image push). No failures.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.



Closes #320
Implemented by dev-lead agent. Please review.