Repository navigation
feat: implement issue #533 — Workflow regression guard requires a stub-level concurrency block the org pr-review template forbids — every standards sync of pr-review.yml fails it - #535
Conversation
…b-level concurrency block the org pr-review template forbids — every standards sync of pr-review.yml fails it
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This comment has been minimized.
This comment has been minimized.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The guard accepts both caller forms as intended. No actionable issue is established from the available evidence. Pre-merge checks |
|
CodeAnt PR Risk: Medium Risk
Assessed commit: |
… org template Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Dev-Lead — review-changes (not-applied)A commit was pushed, but it did not touch any region the review named — the requested changes were not applied. Per requested item:
|
Updated the channel ref from @pr-review/stable to @pr-review/v1-stable in both the uses: line and agent_ref to align with the org template (petry-projects/.github standards/workflows/pr-review.yml) and resolve the SonarQube consistency check. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Fixed in .github/workflows/pr-review.yml: updated the channel tag from @pr-review/stable to @pr-review/v1-stable to align the workflow with the org standard template and resolve the consistency check. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T05:09:56Z. |
|
SonarCloud Quality Gate passed. Analyzed all changed files (pr-review.yml, test-pr-review-workflow.sh, test-pr-review-workflow.test.sh) for hotspot patterns (script injection, hardcoded credentials, dynamic code execution, insecure downloads) — found none. The bash scripts follow best practices with proper safety options and quoting. No security hotspots reported. The reported "1 New issue" is not identifiable from the PR changes or bot output. If this requires action, please provide specifics about the issue location/type. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T05:31:44Z. |
|
No description provided. |
|
No description provided. |
This comment has been minimized.
This comment has been minimized.
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T06:34:43Z. |
This comment has been minimized.
This comment has been minimized.
Dev-Lead — fix-reviews (applied)Changes committed and pushed. Requested items addressed:
|
|
No description provided. |
|
Not a defect: the guard intentionally no longer fails on a top-level |
Dev-Lead — fix-reviews (no-changes)Agent reasoning |
|
No description provided. |
|
This is a rate-limit notice from the code assistant bot indicating its daily quota has been reached. No code changes are needed — the PR's CI checks are all passing and no actionable code findings remain. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Clean code review with no actionable findings. All 5 pre-merge checks passed, and the review confirms the guard now accepts both caller forms (with and without a top-level concurrency block) as intended. No code changes needed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
|
No description provided. |
|
Original reply, kept for the record (unverified — it does not count as a fix):
|
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T21:02:33Z. |
|
dev-lead is withholding action on this item. It is labeled To re-enable automated pickup: remove the |



Problem
Workflow regression guard requires a stub-level concurrency block the org pr-review template forbids — every standards sync of pr-review.yml fails it
From the issue:
scripts/test-pr-review-workflow.sh(run by theWorkflow regression guardscheck) asserts that.github/workflows/pr-review.ymlhas a top-levelconcurrency:block keyed on the PR head SHA withcancel-in-progress: false. The org-standard caller no longer has one, on purpose. The template header inpetry-projects/.githubstandards/workflows/pr-review.ymlsays:Risk
Low — changes automation shell logic under scripts/, covered by shellcheck (--severity=warning) and the bats suite.
Test plan
No test files were added or updated. Verification:
bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
This PR's Lint (shellcheck) and bats checks show pass/fail; watch subsequent dev-lead / pr-review runs for behavioral regressions.
Closes #533
Summary by CodeRabbit