Skip to content

Workflow regression guard requires a stub-level concurrency block the org pr-review template forbids — every standards sync of pr-review.yml fails it #533

Closed

Description

@don-petry

Problem

scripts/test-pr-review-workflow.sh (run by the Workflow regression guards check) asserts that .github/workflows/pr-review.yml has a top-level concurrency: block keyed on the PR head SHA with cancel-in-progress: false. The org-standard caller no longer has one, on purpose. The template header in petry-projects/.github standards/workflows/pr-review.yml says:

All review logic lives in the engine above, including concurrency (per PR + head SHA, never cancelling an in-flight review) … Do not add a stub-level concurrency: block.

So every standards-sync PR that brings this repo's pr-review.yml up to the template fails this repo's own guard. Seen on #532 (2026-10-11), job 114376163824:

FAIL: no top-level 'concurrency.group' block in .github/workflows/pr-review.yml
FAIL: 'concurrency.cancel-in-progress' is not 'false' (found: 'null') in .github/workflows/pr-review.yml

The check is not required by the branch ruleset, so the sync could merge red, leaving main with a failing guard on every run. #532 was closed rather than merged that way; the weekly standards sweep will open the same sync again.

Change

Update the guard to test what is true under the current standard. Do not add a concurrency: block back to pr-review.yml: the stub is synced verbatim from the template and the next sweep would remove it.

Acceptance criteria

  1. scripts/test-pr-review-workflow.sh no longer requires a stub-level concurrency block, and does not forbid one either. This repo's current stub still has the block and the org template does not; the guard runs in ci.yml and must pass on both until the standards sync replaces the stub. It keeps its other checks (file exists, Dependabot skip guard, and so on).
  2. scripts/test-pr-review-workflow.test.sh is updated to match: a stub with no concurrency block passes, and a stub that still has the block also passes. The failure cases for the other checks stay.
  3. The guard passes against both this repo's current pr-review.yml and the org template at petry-projects/.github standards/workflows/pr-review.yml (fetch it in the test or vendor a fixture; say which).
  4. .github/workflows/pr-review.yml is not edited in this change. Its content must be byte-identical to main. The stub changes only through the standards sync, which also sets this repo's ring pin (pr-review/v1-ring1, not v1-stable).

Budget guard

Two files: the guard and its self-test. If the guard's other assertions also turn out to conflict with the template, list them in the PR description and stop; do not edit any workflow stub to make a test pass.

Correction, 2026-10-11

The first version of criterion 1 said the guard should assert that the caller does not define a concurrency block. That contradicted criteria 3 and 4: this repo's current stub has the block, so a guard that forbids it can only pass if the stub is edited. Criteria 1, 2 and 4 above are reworded so all four hold together. Forbidding the block is a separate follow-up for after the standards sync of pr-review.yml has merged here.

Activity

  1. don-petry commented on Oct 11, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #533 — Workflow regression guard requires a stub-level concurrency block the org pr-review template forbids

    Scope

    Invert the guard's concurrency checks: scripts/test-pr-review-workflow.sh will reject any top-level concurrency: block in the pr-review caller (template rule) and keep its other checks; the self-test is updated to match and checks the org template via an inline vendored fixture.

    Implementation Checklist

    • scripts/test-pr-review-workflow.sh: replace Checks 2–4 (concurrency group / head-SHA key / cancel-in-progress) with one check that fails if a top-level concurrency key exists; keep yq, file-exists and Dependabot-guard checks
    • scripts/test-pr-review-workflow.test.sh: fixture builder emits no concurrency block; add a case where a stub that adds one is rejected; add a case for the org template (vendored inline as a heredoc, copied from petry-projects/.github standards/workflows/pr-review.yml at this date, so CI needs no network access)
    • .github/workflows/pr-review.yml is not edited

    Tests to Write

    • a stub with no concurrency block + Dependabot guard → accepted
    • a stub that adds a concurrency: block (even a valid head-SHA one with cancel-in-progress: false) → rejected
    • the vendored org template → accepted
    • the existing Dependabot-guard and missing-file cases stay

    Known conflict

    The checked-in pr-review.yml on main still has the stub-level concurrency: block (#532, the sync that removes it, was closed). AC1 (reject a stub-level block) and AC3 (pass on the current file) can't both hold until that sync lands, and AC4 rules out editing the stub. The guard follows the template, so it will flag the current file as drifted until the next standards sync merges. The PR will call this out.

    Test Command

    bash scripts/test-pr-review-workflow.sh && bash scripts/test-pr-review-workflow.test.sh

  2. don-petry commented on Oct 11, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Progress (in progress — not yet durable)

    Provisional. Nothing is pushed yet. The automation posts the authoritative completion record (with PR number + head SHA) after the push.

    Files touched (this workspace, not yet pushed)

    • scripts/test-pr-review-workflow.sh: replaced the three concurrency checks (group present / keyed on head SHA / cancel-in-progress: false) with one check that fails if a top-level concurrency key exists. Kept the yq, file-exists and Dependabot-guard checks.
    • scripts/test-pr-review-workflow.test.sh: the fixture no longer has a concurrency block. The old cancel-in-progress: true case is now "a stub that adds a concurrency block is rejected". Added a case where the org template is accepted, using an inline vendored copy of petry-projects/.github standards/workflows/pr-review.yml (fetched 2026-10-11; no network needed in CI).
    • .github/workflows/pr-review.yml: not edited.

    ⚠️ Acceptance criteria conflict (needs maintainer attention)

    main's .github/workflows/pr-review.yml still has the stub-level concurrency: block. #532, the sync that would remove it, was closed. So AC1 (reject a stub-level block) and AC3 (pass on the current file) can't both hold until a standards sync lands, and AC4 rules out editing the stub.
    I followed the template: the guard rejects the block. Until the next standards sync of pr-review.yml merges, two things will report the current file as drifted:

    • the guard run directly on the real file (ci.yml "Workflow regression guards")
    • self-test Case 1 ("the checked-in pr-review.yml is accepted")

    Every other self-test case passes locally. With only the concurrency key removed, the current file passes the guard, so the next sync PR should turn the check green. You could merge this together with (or just before) the re-opened sync.

    No other guard assertion conflicts with the template. Its Dependabot guard matches exactly.

  3. don-petry commented on Oct 11, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete — PR #535

    The implementation for issue #533 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

    Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.

  4. added a commit that references this issue on Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions