Skip to content

feat: implement issue #375 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml - #377

Merged
don-petry merged 3 commits into
mainfrom
dev-lead/issue-375-20260718-0820
Jul 18, 2026
Merged

don-petry merged 3 commits into
mainfrom
dev-lead/issue-375-20260718-0820

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #375

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings July 18, 2026 08:28
@don-petry
don-petry requested a review from a team as a code owner July 18, 2026 08:28
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 995e5d71-9d80-4bd2-915d-e81b0685a8f7

📥 Commits

Reviewing files that changed from the base of the PR and between df95d26 and dec42c2.

📒 Files selected for processing (1)
  • .github/workflows/pr-auto-review.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-375-20260718-0820

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 18, 2026 08:30
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-18T09:31:10Z.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tweaks the repo’s PR auto-review “thin caller stub” workflow by reducing the job-level permissions granted to the reusable org workflow.

Changes:

  • Removed statuses: read from the jobs.pr-auto-review.permissions block in .github/workflows/pr-auto-review.yml.

Comment thread .github/workflows/pr-auto-review.yml Resolved
donpetry-bot
donpetry-bot previously approved these changes Jul 18, 2026

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: fe05df2ab9cda8190faa3cb731f75f815e579bc4
Review mode: triage-approved (single reviewer)

Summary

One-line removal of 'statuses: read' from the job-level permissions block of the pr-auto-review.yml thin caller stub. Verified against the canonical template (petry-projects/.github/standards/workflows/pr-auto-review.yml) and the reusable workflow at both the pinned pr-auto-review/v1-ring1 ref and main: none of them declare or require 'statuses: read'. The removed line was pre-existing drift from the org template, and its comment ('required by pr-auto-review-reusable.yml since #435') is stale — #435 in the central repo concerned secret-scanning compliance, not this reusable. The reusable's API calls all use the GH_PAT_WORKFLOWS PAT rather than the job token, so the narrowed grant cannot break it. Triage assessment confirmed.

Linked issue analysis

Issue #375 is a Fleet Monitor health warning (14.3% failure rate, 1 of 7 runs) on .github/workflows/pr-auto-review.yml. The single failure appears transient — recent runs of the workflow are succeeding (the 'action_required' conclusions are fork-approval gates, not failures). The PR remediates the flagged file by removing permissions drift, restoring full-file identity with the org Tier-1 template (modulo the allowed ring1 channel pin). A modest but legitimate remediation; if failures recur, Fleet Monitor will re-flag.

Findings

  • No blocking findings.
  • Secret scan: gitleaks CI check passed; the run_secret_scanning MCP tool is not available in this environment (noted, non-blocking). No secrets in the diff (one deleted YAML line).
  • Least-privilege improvement: the change narrows the caller's token grant to exactly what the reusable declares.
  • Nit (non-blocking): the edit dropped the trailing newline at end of file. Consider restoring it in a future touch.

CI status

All checks green: AgentShield ✓, Secret scan (gitleaks) ✓, CodeQL (actions, python) ✓, SonarCloud quality gate ✓ (0 new issues, 0 hotspots), CodeRabbit status ✓, dependency-audit ✓ (ecosystem jobs skipped — no manifests changed). Remaining skips are expected path-based skips. Mergeable; mergeStateStatus BLOCKED only pending review.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge July 18, 2026 10:07
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 18, 2026 10:10

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: dec42c231dadee30a84c67be7af8c4c7d1261ee0
Review mode: triage-approved (single reviewer)

Summary

One-line removal of 'statuses: read' from the job-level permissions block of the pr-auto-review.yml thin caller stub, plus restoration of the trailing newline at EOF. Independently re-verified at head: the reusable workflow at the pinned pr-auto-review/v1-ring1 ref declares only pull-requests/checks/actions read, and the permissions block now byte-matches the canonical org template (petry-projects/.github/standards/workflows/pr-auto-review.yml). The removed line was pre-existing drift; its stale comment referenced #435, which concerned secret-scanning compliance, not this reusable. Copilot's 'MUST NOT change the permissions block' objection is inverted — the stub rule guards template identity, and this change restores it; that thread is resolved. Triage assessment confirmed.

Linked issue analysis

Issue #375 is a Fleet Monitor health warning (14.3% failure rate, 1 of 7 runs) on .github/workflows/pr-auto-review.yml. The PR remediates the flagged file by removing permissions drift, restoring identity with the org Tier-1 template (modulo the ring1 channel pin, previously deemed an allowed channel ref; compliance checks pass). Modest but legitimate remediation; Fleet Monitor will re-flag if failures recur.

Findings

  • No blocking findings.
  • Changes since prior reviewed commit (fe05df2): merge of main and a fix commit restoring the trailing newline — the prior review's only nit is resolved. No new issues introduced.
  • Least-privilege improvement: caller token grant now exactly matches what the pinned reusable declares.
  • Secret scan: gitleaks CI check passed; the run_secret_scanning MCP tool is not available in this environment (noted, non-blocking). No secret material in the diff.
  • Non-blocking observation (out of scope): the stub's header comment block is an older revision than the current canonical template's header (which now describes the @pr-auto-review/stable channel model). Consider syncing the header text in a future template fanout.

CI status

All checks green: AgentShield ✓, Secret scan (gitleaks) ✓, CodeQL (actions, python) ✓, SonarCloud quality gate ✓ (0 new issues, 0 hotspots), CodeRabbit ✓, dependency-audit ✓ (ecosystem jobs skipped — no manifests changed). Remaining skips are expected path-based skips. Mergeable; mergeStateStatus BLOCKED only pending review.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 0c1c304 into main Jul 18, 2026
21 checks passed
@don-petry
don-petry deleted the dev-lead/issue-375-20260718-0820 branch July 18, 2026 11:18
don-petry added a commit that referenced this pull request Aug 31, 2026
…— .github/workflows/pr-auto-review.yml (#377)

* feat: implement issue #375 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml

* fix(bot): address bot feedback [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>
don-petry added a commit that referenced this pull request Sep 1, 2026
…— .github/workflows/pr-auto-review.yml (#377)

* feat: implement issue #375 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml

* fix(bot): address bot feedback [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>
don-petry added a commit that referenced this pull request Sep 4, 2026
…— .github/workflows/pr-auto-review.yml (#377)

* feat: implement issue #375 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml

* fix(bot): address bot feedback [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>
don-petry added a commit that referenced this pull request Sep 4, 2026
…— .github/workflows/pr-auto-review.yml (#377)

* feat: implement issue #375 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml

* fix(bot): address bot feedback [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/TalkTerm — .github/workflows/pr-auto-review.yml

3 participants