Skip to content

[Fleet Monitor] petry-projects/TalkTerm β€” .github/workflows/sonarcloud.ymlΒ #378

Closed

Description

@don-petry

🟠 DEGRADED: petry-projects/TalkTerm / .github/workflows/sonarcloud.yml

Metric Value
Failure Rate 33.3% (2 / 6 runs)
Status DEGRADED
p50 Duration 45s
p95 Duration 45s
Successful Runs 4
Cancelled Runs 0

Workflow: .github/workflows/sonarcloud.yml

Last updated by Fleet Monitor run on 2026-07-19.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    fleet-trackerTracked by the Actions Fleet Monitor
    health-checkAutomated health check result
    on Jul 19, 2026
  2. don-petry commented on Jul 19, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #378 β€” [Fleet Monitor] petry-projects/TalkTerm β€” .github/workflows/sonarcloud.yml

    Root Cause

    The sonarcloud.yml workflow (added in #377) is incomplete. The SonarCloud Scan step carries an id: sonar and a comment describing a "retry step below" recovering from transient 403/5xx responses from binaries.sonarsource.com, but:

    • The first step is missing continue-on-error: true, and
    • The retry step does not exist.

    So a single CDN blip on the scanner-CLI download fails the whole job β€” matching the observed 33.3% (2/6) failure rate. The canonical org standard (ci-standards.md Β§3) specifies a first attempt with continue-on-error: true followed by a retry step gated on steps.sonar.outcome == 'failure'.

    Scope

    Restore the missing retry mechanism in .github/workflows/sonarcloud.yml so transient scanner-download failures are retried once instead of failing the job.

    Implementation Checklist

    • Add continue-on-error: true to the existing SonarCloud Scan (id: sonar) step
    • Add a SonarCloud Scan (retry) step gated on steps.sonar.outcome == 'failure' (and SONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the file

    Tests to Write

    • No workflow/YAML test harness exists in this repo (no package.json test script, no bats coverage for .github/workflows). Per the Phase 2 config-change exception, no unit test is added. Validation is done by parsing the YAML and running the repo lint (dev-lead-lint.sh).

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh + python3 -c "import yaml,sys; yaml.safe_load(open('.github/workflows/sonarcloud.yml'))"

  3. don-petry commented on Jul 19, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Root Cause

    .github/workflows/sonarcloud.yml was committed incomplete in #377: the SonarCloud Scan step carried an id: sonar and an inline comment referencing a "retry step below," but the continue-on-error: true flag and the retry step itself were both missing. A single transient 403/5xx from binaries.sonarsource.com (the scanner-CLI CDN download) therefore failed the entire job β€” matching the reported 33.3% (2/6) failure rate.

    Plan Execution

    • Added continue-on-error: true to the first SonarCloud Scan (id: sonar) step
    • Added SonarCloud Scan (retry) step gated on steps.sonar.outcome == 'failure' (and SONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the file
    • Validated per the org standard (ci-standards.md Β§3 canonical structure)

    Test Results

    No workflow/YAML test harness exists in this repo (no package.json test script; bats/shellcheck cover scripts/** only, not .github/workflows). Per the Phase 2 config-change exception, validation was done via YAML parsing and repo lint:

    === YAML parse ===
    steps: [None, 'SonarCloud Scan', 'SonarCloud Scan (retry)']
    first continue-on-error: True
    retry if: ${{ env.SONAR_TOKEN != '' && steps.sonar.outcome == 'failure' }}
    === repo lint (dev-lead-lint.sh) ===
      [lint] shellcheck on 4 file(s)...
      [lint] validating CODEOWNERS...
    OK: CODEOWNERS
      [lint] all checks passed
    exit=0
    

    Files Changed

    • .github/workflows/sonarcloud.yml: added continue-on-error: true to the first scan step and appended a SonarCloud Scan (retry) step that re-runs only on first-attempt failure.

    Notes

    • The retry reuses the repo's already-pinned SHA (713881670b… / v8.2.0) rather than the v8.1.0 SHA shown as an example in the standard β€” deliberately avoiding an action downgrade.
    • Edge cases verified: a skipped first step (empty SONAR_TOKEN) yields outcome skipped, not failure, so the retry stays skipped (also double-guarded by the token check); a successful first attempt yields success, so no duplicate scan runs.
    • actionlint is not installed on this runner, so that lint was skipped.
  4. added a commit that references this issue on Jul 19, 2026
  5. added 3 commits that reference this issue on Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupfleet-trackerTracked by the Actions Fleet Monitorhealth-checkAutomated health check result

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions