You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sonarcloud.yml workflow (added in #377) is incomplete. The SonarCloud Scan step carries an id: sonar and a comment describing a "retry step below" recovering from transient 403/5xx responses from binaries.sonarsource.com, but:
The first step is missing continue-on-error: true, and
The retry step does not exist.
So a single CDN blip on the scanner-CLI download fails the whole job β matching the observed 33.3% (2/6) failure rate. The canonical org standard (ci-standards.md Β§3) specifies a first attempt with continue-on-error: true followed by a retry step gated on steps.sonar.outcome == 'failure'.
Scope
Restore the missing retry mechanism in .github/workflows/sonarcloud.yml so transient scanner-download failures are retried once instead of failing the job.
Implementation Checklist
Add continue-on-error: true to the existing SonarCloud Scan (id: sonar) step
Add a SonarCloud Scan (retry) step gated on steps.sonar.outcome == 'failure' (and SONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the file
Tests to Write
No workflow/YAML test harness exists in this repo (no package.json test script, no bats coverage for .github/workflows). Per the Phase 2 config-change exception, no unit test is added. Validation is done by parsing the YAML and running the repo lint (dev-lead-lint.sh).
.github/workflows/sonarcloud.yml was committed incomplete in #377: the SonarCloud Scan step carried an id: sonar and an inline comment referencing a "retry step below," but the continue-on-error: true flag and the retry step itself were both missing. A single transient 403/5xx from binaries.sonarsource.com (the scanner-CLI CDN download) therefore failed the entire job β matching the reported 33.3% (2/6) failure rate.
Plan Execution
Added continue-on-error: true to the first SonarCloud Scan (id: sonar) step
Added SonarCloud Scan (retry) step gated on steps.sonar.outcome == 'failure' (and SONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the file
Validated per the org standard (ci-standards.md Β§3 canonical structure)
Test Results
No workflow/YAML test harness exists in this repo (no package.json test script; bats/shellcheck cover scripts/** only, not .github/workflows). Per the Phase 2 config-change exception, validation was done via YAML parsing and repo lint:
.github/workflows/sonarcloud.yml: added continue-on-error: true to the first scan step and appended a SonarCloud Scan (retry) step that re-runs only on first-attempt failure.
Notes
The retry reuses the repo's already-pinned SHA (713881670bβ¦ / v8.2.0) rather than the v8.1.0 SHA shown as an example in the standard β deliberately avoiding an action downgrade.
Edge cases verified: a skipped first step (empty SONAR_TOKEN) yields outcome skipped, not failure, so the retry stays skipped (also double-guarded by the token check); a successful first attempt yields success, so no duplicate scan runs.
actionlint is not installed on this runner, so that lint was skipped.
Activity
don-petry commentedon Jul 19, 2026
Dev-Lead Implementation Plan
Issue: #378 β [Fleet Monitor] petry-projects/TalkTerm β .github/workflows/sonarcloud.yml
Root Cause
The
sonarcloud.ymlworkflow (added in #377) is incomplete. TheSonarCloud Scanstep carries anid: sonarand a comment describing a "retry step below" recovering from transient403/5xxresponses frombinaries.sonarsource.com, but:continue-on-error: true, andSo a single CDN blip on the scanner-CLI download fails the whole job β matching the observed 33.3% (2/6) failure rate. The canonical org standard (
ci-standards.mdΒ§3) specifies a first attempt withcontinue-on-error: truefollowed by a retry step gated onsteps.sonar.outcome == 'failure'.Scope
Restore the missing retry mechanism in
.github/workflows/sonarcloud.ymlso transient scanner-download failures are retried once instead of failing the job.Implementation Checklist
continue-on-error: trueto the existingSonarCloud Scan(id: sonar) stepSonarCloud Scan (retry)step gated onsteps.sonar.outcome == 'failure'(andSONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the fileTests to Write
package.jsontest script, no bats coverage for.github/workflows). Per the Phase 2 config-change exception, no unit test is added. Validation is done by parsing the YAML and running the repo lint (dev-lead-lint.sh).Test Command
bash .dev-lead/scripts/dev-lead-lint.sh+python3 -c "import yaml,sys; yaml.safe_load(open('.github/workflows/sonarcloud.yml'))"don-petry commentedon Jul 19, 2026
Dev-Lead: Implementation Complete
Root Cause
.github/workflows/sonarcloud.ymlwas committed incomplete in #377: theSonarCloud Scanstep carried anid: sonarand an inline comment referencing a "retry step below," but thecontinue-on-error: trueflag and the retry step itself were both missing. A single transient403/5xxfrombinaries.sonarsource.com(the scanner-CLI CDN download) therefore failed the entire job β matching the reported 33.3% (2/6) failure rate.Plan Execution
continue-on-error: trueto the firstSonarCloud Scan(id: sonar) stepSonarCloud Scan (retry)step gated onsteps.sonar.outcome == 'failure'(andSONAR_TOKEN != ''), reusing the same pinned action SHA (v8.2.0) already in the fileci-standards.mdΒ§3 canonical structure)Test Results
No workflow/YAML test harness exists in this repo (no
package.jsontest script; bats/shellcheck coverscripts/**only, not.github/workflows). Per the Phase 2 config-change exception, validation was done via YAML parsing and repo lint:Files Changed
.github/workflows/sonarcloud.yml: addedcontinue-on-error: trueto the first scan step and appended aSonarCloud Scan (retry)step that re-runs only on first-attempt failure.Notes
713881670bβ¦/ v8.2.0) rather than the v8.1.0 SHA shown as an example in the standard β deliberately avoiding an action downgrade.SONAR_TOKEN) yields outcomeskipped, notfailure, so the retry stays skipped (also double-guarded by the token check); a successful first attempt yieldssuccess, so no duplicate scan runs.actionlintis not installed on this runner, so that lint was skipped.feat: implement issue #378 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #378 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #378 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #378 β [Fleet Monitor] petry-projects/TalkTerm β¦