You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The 2 failing runs in the monitored window were both on the feature branch worktree-implement-sprint-1, in the quality matrix job at the npm run test:coverage step:
ERROR: Coverage for branches (89.73%) does not meet global threshold (90%)
That is legitimate quality-gate enforcement, not workflow flakiness β the CI
correctly failed branch code that missed the 90% branch-coverage threshold. That
gate will not be weakened.
Scope
Following the repo's established pattern (Fleet Monitor #380 concurrency, #430 yq
checksum, #438 curl --retry β each a durable invariant locked by a regression
guard), harden ci.yml against the remaining CI-inflating failure class it does
not yet defend: jobs with no timeout-minutes. Without a job timeout, a
stalled step (a curl that connects then hangs β --retry does not cover stalls β
or any hung process) runs to GitHub's 6-hour default before being killed and
counted as a timeout failure. p95 duration is 150s, so any multi-minute run is
anomalous. timeout-minutes is already a convention in 4 sibling workflows
(sonarcloud, copilot-setup-steps, initiative-driver, feature-ideation).
Implementation Checklist
.github/workflows/ci.yml β add timeout-minutes to both jobs (secret-scan, workflow-tests)
scripts/test-ci-workflow.sh β add Check 7: every job must declare a positive-integer timeout-minutes
scripts/test-ci-workflow.test.sh β add fixtures/cases: reject a job missing timeout-minutes, accept jobs that declare it
Tests to Write
Case: workflow with a job missing timeout-minutes is REJECTED
Case: workflow whose every job declares timeout-minutes is ACCEPTED
Case: timeout-minutes: 0 (invalid) is REJECTED
Re-run existing guard against the real ci.yml after the fix β passes
Test Command
bash scripts/test-ci-workflow.sh && bash scripts/test-ci-workflow.test.sh (full guard suite via scripts/test-*-workflow*.sh)
The 2 failing runs in the monitored window were not workflow flakiness. Both were
on the feature branch worktree-implement-sprint-1, in the quality matrix job at npm run test:coverage:
ERROR: Coverage for branches (89.73%) does not meet global threshold (90%)
That is the CI correctly enforcing the 90% branch-coverage gate against branch code β
legitimate quality-gate enforcement, not a defect in ci.yml. That gate was not
weakened. Instead, following the repo's established pattern (Fleet Monitor #380 concurrency, #430 yq checksum, #438 curl --retry β each a durable invariant locked by a regression
guard), I hardened ci.yml against the remaining CI-inflating failure class it did not yet
defend: jobs with no timeout-minutes.
Plan Execution
Investigated the 2 failing runs (legitimate coverage-gate failures, not flakiness)
Added timeout-minutes: 10 to both ci.yml jobs (secret-scan, workflow-tests)
Added Check 7 to scripts/test-ci-workflow.sh: every job must declare a positive-integer timeout-minutes
Added TDD cases 10β12 to scripts/test-ci-workflow.test.sh (confirmed red β green)
Full guard suite, shellcheck (warning), and .dev-lead/scripts/dev-lead-lint.sh all pass
Why timeout-minutes
Without a job timeout, a step that stalls rather than errors β a curl that connects then
hangs (which --retry does not cover), or any wedged process β runs to GitHub's 6-hour
default before being killed and counted as a timeout failure, inflating the failure rate and
burning runner minutes. p95 for this workflow is ~150s, so timeout-minutes: 10 is ample
headroom and turns a hang into a fast, obvious failure. This mirrors the convention already
used by sonarcloud.yml, copilot-setup-steps.yml, initiative-driver.yml and feature-ideation.yml.
Test Results
=== test-ci-workflow ===
PASS: 'yq' is available
PASS: .github/workflows/ci.yml exists
PASS: 'concurrency.group' block present in .github/workflows/ci.yml
PASS: concurrency group keyed on github.ref in .github/workflows/ci.yml
PASS: 'concurrency.cancel-in-progress' is unconditionally true in .github/workflows/ci.yml
PASS: 'Install yq' extracts the SHA-256 (column 19) in .github/workflows/ci.yml
PASS: every 'curl' download retries on transient failures in .github/workflows/ci.yml
PASS: job 'secret-scan' declares timeout-minutes (10) in .github/workflows/ci.yml
PASS: job 'workflow-tests' declares timeout-minutes (10) in .github/workflows/ci.yml
All checks passed.
--- test-ci-workflow.test.sh ---
ok - buggy yq extraction is rejected
ok - correct yq extraction (^yq_linux_amd64 / column 19) is accepted
ok - workflow without an Install yq step passes (check skipped)
ok - workflow missing a concurrency block is rejected
ok - decoy $19 in unnamed step does not rescue buggy Install yq
ok - correct Install yq with following unnamed step is accepted
ok - curl download without --retry is rejected
ok - curl downloads with --retry (multi-line continuation) are accepted
ok - curl without --retry chained with one that has --retry is rejected
ok - every job declaring timeout-minutes is accepted
ok - a job missing timeout-minutes is rejected
ok - timeout-minutes: 0 is rejected
All tests passed.
Full workflow-tests job suite (all 7 scripts/test-*-workflow*.sh) also passes.
Files Changed
.github/workflows/ci.yml: added timeout-minutes: 10 to both jobs with explanatory comments
scripts/test-ci-workflow.test.sh: added fixtures + Cases 10β12 (accept when present, reject when missing, reject timeout-minutes: 0); backfilled timeout-minutes into existing fixtures so each still isolates its intended defect
Notes
The observed 2 failures are a per-branch coverage issue for that PR's author to resolve, not a ci.yml defect. Edge cases covered by the guard: missing value, non-integer/expression values,
and zero are all rejected; hyphenated job names are handled via yq env() lookup. No git
operations performed β left to the CI workflow.
Activity
don-petry commentedon Sep 1, 2026
Dev-Lead Implementation Plan
Issue: #470 β [Fleet Monitor] petry-projects/TalkTerm β .github/workflows/ci.yml
Investigation
The 2 failing runs in the monitored window were both on the feature branch
worktree-implement-sprint-1, in thequalitymatrix job at thenpm run test:coveragestep:That is legitimate quality-gate enforcement, not workflow flakiness β the CI
correctly failed branch code that missed the 90% branch-coverage threshold. That
gate will not be weakened.
Scope
Following the repo's established pattern (Fleet Monitor #380 concurrency, #430 yq
checksum, #438 curl
--retryβ each a durable invariant locked by a regressionguard), harden
ci.ymlagainst the remaining CI-inflating failure class it doesnot yet defend: jobs with no
timeout-minutes. Without a job timeout, astalled step (a curl that connects then hangs β
--retrydoes not cover stalls βor any hung process) runs to GitHub's 6-hour default before being killed and
counted as a timeout failure. p95 duration is 150s, so any multi-minute run is
anomalous.
timeout-minutesis already a convention in 4 sibling workflows(sonarcloud, copilot-setup-steps, initiative-driver, feature-ideation).
Implementation Checklist
.github/workflows/ci.ymlβ addtimeout-minutesto both jobs (secret-scan,workflow-tests)scripts/test-ci-workflow.shβ add Check 7: every job must declare a positive-integertimeout-minutesscripts/test-ci-workflow.test.shβ add fixtures/cases: reject a job missingtimeout-minutes, accept jobs that declare itTests to Write
timeout-minutesis REJECTEDtimeout-minutesis ACCEPTEDtimeout-minutes: 0(invalid) is REJECTEDci.ymlafter the fix β passesTest Command
bash scripts/test-ci-workflow.sh && bash scripts/test-ci-workflow.test.sh(full guard suite viascripts/test-*-workflow*.sh)don-petry commentedon Sep 1, 2026
Dev-Lead: Implementation Complete
Investigation summary
The 2 failing runs in the monitored window were not workflow flakiness. Both were
on the feature branch
worktree-implement-sprint-1, in thequalitymatrix job atnpm run test:coverage:That is the CI correctly enforcing the 90% branch-coverage gate against branch code β
legitimate quality-gate enforcement, not a defect in
ci.yml. That gate was notweakened. Instead, following the repo's established pattern (Fleet Monitor #380 concurrency,
#430 yq checksum, #438 curl
--retryβ each a durable invariant locked by a regressionguard), I hardened
ci.ymlagainst the remaining CI-inflating failure class it did not yetdefend: jobs with no
timeout-minutes.Plan Execution
timeout-minutes: 10to bothci.ymljobs (secret-scan,workflow-tests)scripts/test-ci-workflow.sh: every job must declare a positive-integertimeout-minutesscripts/test-ci-workflow.test.sh(confirmed red β green).dev-lead/scripts/dev-lead-lint.shall passWhy timeout-minutes
Without a job timeout, a step that stalls rather than errors β a curl that connects then
hangs (which
--retrydoes not cover), or any wedged process β runs to GitHub's 6-hourdefault before being killed and counted as a timeout failure, inflating the failure rate and
burning runner minutes. p95 for this workflow is ~150s, so
timeout-minutes: 10is ampleheadroom and turns a hang into a fast, obvious failure. This mirrors the convention already
used by
sonarcloud.yml,copilot-setup-steps.yml,initiative-driver.ymlandfeature-ideation.yml.Test Results
Full
workflow-testsjob suite (all 7scripts/test-*-workflow*.sh) also passes.Files Changed
.github/workflows/ci.yml: addedtimeout-minutes: 10to both jobs with explanatory commentsscripts/test-ci-workflow.sh: added Check 7 (every job declares a positive-integertimeout-minutes); refreshed header docstringscripts/test-ci-workflow.test.sh: added fixtures + Cases 10β12 (accept when present, reject when missing, rejecttimeout-minutes: 0); backfilledtimeout-minutesinto existing fixtures so each still isolates its intended defectNotes
The observed 2 failures are a per-branch coverage issue for that PR's author to resolve, not a
ci.ymldefect. Edge cases covered by the guard: missing value, non-integer/expression values,and zero are all rejected; hyphenated job names are handled via
yq env()lookup. No gitoperations performed β left to the CI workflow.
feat: implement issue #470 β [Fleet Monitor] petry-projects/TalkTerm β¦
fix: add timeout-minutes to quality, mutation, and e2e CI jobs
feat: implement issue #470 β [Fleet Monitor] petry-projects/TalkTerm β¦
feat: implement issue #470 β [Fleet Monitor] petry-projects/TalkTerm β¦
fix: add timeout-minutes to quality, mutation, and e2e CI jobs