Skip to content

[Fleet Monitor] petry-projects/TalkTerm β€” .github/workflows/ci.ymlΒ #430

Closed

Description

@don-petry

🟠 DEGRADED: petry-projects/TalkTerm / .github/workflows/ci.yml

Metric Value
Failure Rate 40% (2 / 5 runs)
Status DEGRADED
p50 Duration 12s
p95 Duration 22s
Successful Runs 3
Cancelled Runs 0

Workflow: .github/workflows/ci.yml

Last updated by Fleet Monitor run on 2026-08-13.
Threshold: failure rate > 10% over the monitored window.

Activity

  1. added
    dev-leadFor dev-lead agent pickup
    fleet-trackerTracked by the Actions Fleet Monitor
    health-checkAutomated health check result
    on Aug 13, 2026
  2. don-petry commented on Aug 13, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #430 β€” [Fleet Monitor] petry-projects/TalkTerm β€” .github/workflows/ci.yml

    Root Cause

    The 2 failing runs in the monitored window were both PR runs whose ci.yml carried a
    Workflow regression guards (workflow-tests) job (introduced by in-flight PR #429). Its
    Install yq step died deterministically with:

    sha256sum: 'standard input': no properly formatted checksum lines found
    

    The mikefarah/yq checksums release asset is a multi-hash table: the asset filename is
    column 1 (at the start of each line) and SHA-256 is column 19 (per
    checksums_hashes_order). The buggy step used grep "yq_linux_amd64$" | awk '{print $1}' β€”
    an end-anchored match that never matches (filename is at line start), yielding an empty
    checksum and a hard failure. (Verified: column 19 == the real SHA-256 of yq_linux_amd64.)

    Scope

    Lock the correct yq-checksum-extraction invariant into ci.yml's existing Fleet Monitor
    regression guard (scripts/test-ci-workflow.sh, from #380) so this exact drift can never
    recur, following the established per-workflow guard convention (#374, #380, #428). No change
    to ci.yml itself is made here (the buggy step is not on main; PR #429 already carries the
    corrected $19 extraction) β€” the guard enforces correctness whenever that job lands.

    Implementation Checklist

    • scripts/test-ci-workflow.sh β€” accept optional WORKFLOW arg (mirrors sibling
      test-dependabot-rebase-workflow.sh) to enable fixture testing
    • scripts/test-ci-workflow.sh β€” add Check 5: if an Install yq step is present, its
      checksums extraction must anchor the filename at line start and select the SHA-256
      column ($19), never the filename column ($1); skips cleanly when no yq step exists

    Tests to Write

    • scripts/test-ci-workflow.test.sh β€” fixture-based red/green tests:
      • buggy yq block (yq_linux_amd64$ / $1) β†’ guard FAILS (red)
      • correct yq block (^yq_linux_amd64 / $19) β†’ guard PASSES (green)
      • no yq step β†’ guard PASSES (skip path)
      • existing concurrency invariants still enforced

    Test Command

    bash scripts/test-ci-workflow.test.sh && bash scripts/test-ci-workflow.sh

  3. don-petry commented on Aug 13, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Root Cause (confirmed)

    Both failing runs in the monitored window were PR runs whose ci.yml carried a
    Workflow regression guards (workflow-tests) job introduced by in-flight PR #429. Its
    Install yq step failed deterministically with sha256sum: 'standard input': no properly formatted checksum lines found. The mikefarah/yq checksums asset is a multi-hash table β€”
    the asset filename is column 1 (at line start) and SHA-256 is column 19 (per
    checksums_hashes_order, verified against the real binary hash). The buggy step used
    grep "yq_linux_amd64$" | awk '{print $1}': the end-anchor never matches and column 1 is the
    filename, so EXPECTED was empty. secret-scan (the only job on main) was green throughout.

    Plan Execution

    • Diagnosed the two failing runs β†’ Install yq checksum-extraction bug
    • Verified column 19 == SHA-256 of yq_linux_amd64 from the live release asset
    • Wrote fixture-based tests first (red), then implemented (green)
    • Added optional-arg support + Check 5 to the existing ci.yml regression guard
    • Ran required lint (dev-lead-lint.sh), shellcheck, and every repo guard/test script

    Test Results

    ok   - buggy yq extraction is rejected
    ok   - correct yq extraction (^yq_linux_amd64 / column 19) is accepted
    ok   - workflow without an Install yq step passes (check skipped)
    ok   - workflow missing a concurrency block is rejected
    
    All tests passed.
    
    $ bash scripts/test-ci-workflow.sh   # against real ci.yml
    PASS: no 'Install yq' step in .github/workflows/ci.yml β€” yq checksum check not applicable
    
    All checks passed.
    
    $ bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] validating CODEOWNERS...
    OK: CODEOWNERS
      [lint] all checks passed
    
    $ shellcheck --severity=warning -x scripts/test-ci-workflow*.sh
    clean
    

    Files Changed

    • scripts/test-ci-workflow.sh: accept an optional workflow-path arg (mirrors sibling
      test-dependabot-rebase-workflow.sh); add Check 5 β€” if an Install yq step is present,
      its checksums extraction must anchor the filename at line start and select the SHA-256
      column ($19), never an end-anchor or column 1. No-op when no yq step exists.
    • scripts/test-ci-workflow.test.sh (new): fixture-based red/green tests covering the buggy
      extraction (rejected), the correct extraction (accepted), the no-yq skip path, and the
      existing concurrency invariant.

    Notes

  4. added a commit that references this issue on Aug 13, 2026
  5. added 3 commits that reference this issue on Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupfleet-trackerTracked by the Actions Fleet Monitorhealth-checkAutomated health check result

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions