Skip to content

ci(dev-lead): enable dev-lead-issue-retry dispatch type (#781) - #292

Merged
don-petry merged 3 commits into
mainfrom
claude/dev-lead-issue-retry-781
Jun 20, 2026
Merged

don-petry merged 3 commits into
mainfrom
claude/dev-lead-issue-retry-781

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Summary

Re-syncs this repo's dev-lead.yml caller stub with the updated canonical template (petry-projects/.github → standards/workflows/dev-lead.yml).

Adds the two missing repository_dispatch types the dev-lead-retry cron emits:

   repository_dispatch:
-    types: [dev-lead-ci-failure]
+    types: [dev-lead-ci-failure, dev-lead-reviews-retry, dev-lead-issue-retry]

This is the only change — a one-line trigger addition. The pin, agent_ref, permissions, and concurrency contract are untouched. Companion to combsmith/.github#494 (template + docs) and combsmith/.github-private#810 (implementation).

🤖 Generated with Claude Code

@don-petry
don-petry requested a review from a team as a code owner June 19, 2026 22:53
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: db41d1d8-7ad5-40aa-bf16-3f5cb23d9b11

📥 Commits

Reviewing files that changed from the base of the PR and between 90922e9 and 664e7fa.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/dev-lead-issue-retry-781

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- No actionable code issues identified in the bot comment
Files changed: .github/workflows/dev-lead.yml (no fixes needed)
Skipped (non-actionable): 1 (Codex usage limit notification)
```
The PR is ready pending CI completion. The workflow changes are sound and require no modifications.

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 22:55
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 19, 2026 22:57
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-19T23:59:00Z.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
- ✅ 0 Accepted issues  
- ✅ 0 Security Hotspots
- ✅ 0.0% Coverage on New Code
- ✅ 0.0% Duplication on New Code
**Files changed:** `.github/workflows/dev-lead.yml` (added two new dispatch types: `dev-lead-reviews-retry`, `dev-lead-issue-retry`)
**Tier 1 Blockers noted (non-actionable):**
- Two cancelled workflow jobs: "dev-lead / dispatch" and "dev-lead / ci-relay"
  - These appear to be cancelled due to normal workflow concurrency management (the dev-lead workflow is configured to limit concurrent runs per PR, so earlier runs get cancelled when new commits push)
  - This is infrastructure behavior, not a code quality issue from the bot
**Conclusion:** No code changes required. The SonarCloud bot found no issues to fix, and all other CI checks pass (Format, Test, Secret scan, CodeQL, Lint, etc. all show SUCCESS).

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 23:00

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 664e7faa0e97c9076c27a3a2f2afe96b2d322195
Review mode: triage-approved (single reviewer)

Summary

One-line CI change to the dev-lead.yml caller stub: adds two repository_dispatch trigger types (dev-lead-reviews-retry, dev-lead-issue-retry) so the dev-lead-retry cron's dispatches are handled. Re-syncs the stub with the canonical petry-projects/.github template. permissions: {} stays empty; pin, agent_ref, and concurrency contract are untouched.

Linked issue analysis

No formal closingIssuesReferences. The PR references combsmith/.github-private#781 as motivation (bounded auto-retry of failed initial issue implementations) and is a companion to .github#494 and .github-private#810. The change is a CI-infra template sync, not an issue fix; the diff matches the stated intent exactly.

Findings

  • No security-relevant changes. The diff only widens the repository_dispatch types array by two entries; permissions remain {}, and the action pin/agent_ref/concurrency are unchanged.
  • repository_dispatch events require an authenticated API call to emit, so the added trigger types do not broaden the external attack surface.
  • Secret-scanning MCP unavailable (GitHub Advanced Security not enabled for this repo); the gitleaks CI check passed.
  • No unresolved human-review threads; advisory-bot comments are rate-limit/usage notices, not findings.

CI status

Genuine quality gates green: Lint, Format, Test, Secret scan (gitleaks), CodeQL/Analyze (actions), SonarCloud, AgentShield, dependency-audit (Detect ecosystems), pr-auto-review, review. Two dev-lead self-jobs (dispatch, ci-relay) are CANCELLED by normal per-PR concurrency management — expected, non-blocking. mergeStateStatus=BLOCKED only because org-leads review is required.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 5cb1f9b into main Jun 20, 2026
20 of 22 checks passed
@don-petry
don-petry deleted the claude/dev-lead-issue-retry-781 branch June 20, 2026 01:37
@github-actions

Copy link
Copy Markdown
Contributor

CI Failure: SonarCloud Code Analysis

Step: SonarCloud Quality Gate (main branch post-merge analysis)
Root cause: Lint/style

SonarCloud reported 14 new Security Hotspots on the main branch after this PR was merged, causing the Quality Gate to fail. Security Hotspots are code patterns flagged by static analysis as potentially risky (e.g. hardcoded credentials, unsafe API usage, weak cryptography) that require a human reviewer to confirm whether they represent actual vulnerabilities. This PR only modified a workflow YAML trigger list, so the hotspots likely originate from other recently merged code or a shift in SonarCloud's detection rules applied to the full main branch scan.

Suggested fix: Open the SonarCloud Security Hotspots dashboard, review each of the 14 flagged hotspots, and mark them as Safe (if not exploitable) or create follow-up issues for any that are genuine risks — this will resolve the Quality Gate failure.

View analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants