Skip to content

docs(dev-lead): document + enable dev-lead-issue-retry dispatch type (#781) - #494

Merged
don-petry merged 4 commits into
mainfrom
claude/dev-lead-issue-retry-781
Jun 20, 2026
Merged

don-petry merged 4 commits into
mainfrom
claude/dev-lead-issue-retry-781

Conversation

@don-petry

@don-petry don-petry commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Companion to combsmith/.github-private#810 (Closes combsmith/.github-private#781), which makes a failed initial issue implementation never-silent (cause marker + redacted snippet on the issue) and gives it a bounded auto-retry via the dev-lead-retry cron — a new dev-lead-issue-retry repository_dispatch.

For that retry to actually reach a repo, the repo's dev-lead.yml caller stub must list dev-lead-issue-retry in on.repository_dispatch.types. The canonical template (standards/workflows/dev-lead.yml) only had [dev-lead-ci-failure] — it never even gained dev-lead-reviews-retry, so cron-driven retries only worked where a stub had been manually advanced (e.g. .github-private's inline workflow). This PR brings the template — and this repo's own stub — in line with the full set the cron emits.

Changes

Why this is non-breaking

check_dev_lead_stub() in compliance-audit.sh validates only the stub's pin / agent_ref / no-concurrency / statuses: read — not the repository_dispatch.types list (triggers are explicitly stub-editable per the stub header). So this adds no compliance findings: consumers without the new type simply don't receive issue retries until their stub is re-synced — graceful degradation, identical to today's behaviour for dev-lead-reviews-retry.

Follow-up

Consumer dev-lead.yml stubs across the org should be re-synced from the updated template (via the standard stub-sync process) to pick up both retry types. That mass re-sync is intentionally not part of this PR.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Expanded guidance on handling failures for issue-based implementations with automated retry logic (up to 3 attempts) before escalation.
  • Chores

    • Enhanced CI workflow to support additional retry event types for improved failure recovery handling.

…ombsmith/.github-private#781)

Companion to combsmith/.github-private#810, which gives failed initial
issue implementations a cause-bearing failure marker and a bounded auto-retry
via the dev-lead-retry cron (new dev-lead-issue-retry repository_dispatch).

For that retry to reach a consumer, the consumer's dev-lead.yml caller stub must
list dev-lead-issue-retry in on.repository_dispatch.types. The canonical template
had only [dev-lead-ci-failure] — it never gained dev-lead-reviews-retry either,
so cron-driven retries only worked where a stub was manually ahead. This brings
the template (and this repo's own stub) in line with the full set the cron emits:
  [dev-lead-ci-failure, dev-lead-reviews-retry, dev-lead-issue-retry]

- standards/workflows/dev-lead.yml — canonical template gains both retry types.
- .github/workflows/dev-lead.yml — this repo runs dev-lead on its own issues
  (where #478 stalled), so its stub gets the same types.
- standards/ci-standards.md — new "Failed issue implementations" subsection
  (cause marker, bounded retry, dev-lead:needs-human escalation) + runbook update
  for the exit-124 timeout row.

The dispatch-type list is not enforced by check_dev_lead_stub (it validates only
the pin/agent_ref/concurrency/permissions), so this is non-breaking: consumers
without the type simply don't receive issue retries until re-synced.

Refs combsmith/.github-private#781

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner June 19, 2026 22:08
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 34880813-067c-471c-8b27-0e25d6ed324b

📥 Commits

Reviewing files that changed from the base of the PR and between 4c7e988 and 0e5720c.

📒 Files selected for processing (3)
  • .github/workflows/dev-lead.yml
  • standards/ci-standards.md
  • standards/workflows/dev-lead.yml

📝 Walkthrough

Walkthrough

Two workflow files (.github/workflows/dev-lead.yml and standards/workflows/dev-lead.yml) each expand their on.repository_dispatch.types list to include dev-lead-reviews-retry and dev-lead-issue-retry alongside the existing dev-lead-ci-failure. standards/ci-standards.md adds a documentation subsection and updates a runbook row to describe the bounded retry and escalation behavior for failed initial issue implementations.

Changes

Dev-lead issue-retry dispatch expansion

Layer / File(s) Summary
Workflow trigger expansion (live + standards stub)
.github/workflows/dev-lead.yml, standards/workflows/dev-lead.yml
Both workflow files add dev-lead-reviews-retry and dev-lead-issue-retry to the on.repository_dispatch.types allowlist, alongside the existing dev-lead-ci-failure.
CI-standards documentation and runbook update
standards/ci-standards.md
New subsection documents labeled-issue failure classification, cause-bearing issue markers, the dev-lead-retry cron re-dispatching dev-lead-issue-retry (max 3 attempts, rate-limit-aware), caller-stub repository_dispatch.types requirements, deterministic infra failure bypass, and dev-lead:needs-human escalation. The exit-code 124 runbook row is updated to reference this new behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

  • #781 — dev-lead retry doesn't cover failed initial issue implementations (only rate-limited PRs) — issues silently stall: This PR directly addresses the issue by adding dev-lead-issue-retry to the workflow dispatch allowlist and documenting a bounded 3-attempt retry path with dev-lead:needs-human escalation, which resolves the silent-stall acceptance criteria described in #781.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #781 by enabling the dispatch type and documenting the retry process, but does not implement the actual bounded retry mechanism or failure marking logic. Implement the bounded auto-retry mechanism (marking failed issues, scanning for markers, attempt ceiling) and add tests for the failed-issue-implementation path to fully satisfy acceptance criteria.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: enabling the dev-lead-issue-retry dispatch type and documenting its behavior.
Out of Scope Changes check ✅ Passed All changes are directly scoped to enabling the dev-lead-issue-retry dispatch type and documenting the retry behavior; no unrelated alterations detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/dev-lead-issue-retry-781

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation and configuration for a new visibility and bounded auto-retry mechanism for failed issue implementations before a PR is created. It details how failures are classified, surfaced on the issue, and retried up to three times, and updates the dev-lead.yml workflow template to support the new dev-lead-reviews-retry and dev-lead-issue-retry repository dispatch types. The feedback suggests correcting a spelling inconsistency ("labelled" to "labeled") in the documentation for consistency.

Comment thread standards/ci-standards.md Resolved
@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 22:09
@don-petry
don-petry disabled auto-merge June 19, 2026 22:09
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 19, 2026
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 22:12
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-19T23:15:21Z.

@don-petry
don-petry disabled auto-merge June 20, 2026 00:37
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 20, 2026 00:41

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 5bbad6ec2f7340b9bd195f3203ffd805b7a9e2f2
Review mode: triage-approved (single reviewer)

Summary

Companion to .github-private#810/#781. Adds the missing repository_dispatch types dev-lead-reviews-retry and dev-lead-issue-retry to both the canonical template (standards/workflows/dev-lead.yml) and this repo's own dev-lead.yml stub, plus a new ci-standards.md subsection documenting the failed-issue visibility + bounded (3-attempt) auto-retry path and a runbook update on the exit-code-124 timeout row. 28 additions across 3 files.

Linked issue analysis

Closes combsmith/.github-private#781 (failed issue implementations should be non-silent + auto-retried). This PR supplies the trigger-plumbing half: a consumer stub must list dev-lead-issue-retry in on.repository_dispatch.types for the cron's re-dispatch to reach it. The template + docs changes substantively advance that goal; the engine/cron behavior itself lands in the companion .github-private#810.

Findings

No blocking findings.

  • The dev-lead.yml stub header explicitly states it 'may be freely modified on PR branches to adjust triggers for repo-specific needs', so editing repository_dispatch.types is in-scope for a thin caller stub (unlike claude.yml's byte-for-byte OIDC constraint).
  • permissions: {} is unchanged — no permission escalation. repository_dispatch can only be fired by a write-credentialed API caller, so adding named types introduces no new untrusted-actor attack surface.
  • Non-breaking per PR rationale: compliance-audit.sh check_dev_lead_stub() validates pin/agent_ref/no-concurrency/statuses:read, not the trigger type list; consumers without the new type simply don't receive issue retries (graceful degradation, identical to today's dev-lead-reviews-retry behavior).
  • Docs (ci-standards.md) are internally consistent: anchor link, marker format, 3-attempt ceiling, and dev-lead:needs-human escalation all align with the PR description.
  • Secret-scanning MCP unavailable (repo lacks GitHub Advanced Security); gitleaks CI check passed and the diff contains only event-type identifiers and markdown — no credential material.

CI status

All required checks green: Lint, ShellCheck, CodeQL, SonarCloud, agent-shield/AgentShield, Agent Security Scan, Secret scan (gitleaks), dev-lead/dispatch, pr-auto-review, CodeRabbit. Language-specific audit jobs (npm/pnpm/pip/cargo/govulncheck) SKIPPED as expected (no matching ecosystem). mergeStateStatus BLOCKED only on REVIEW_REQUIRED.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge June 20, 2026 03:17
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #494
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-20T03:48:47Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-20T03:48:47Z

@don-petry
don-petry merged commit b8ce5a2 into main Jun 20, 2026
31 of 38 checks passed
@don-petry
don-petry deleted the claude/dev-lead-issue-retry-781 branch June 20, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev-lead retry doesn't cover failed initial issue implementations (only rate-limited PRs) — issues silently stall

2 participants