Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/pr-review-trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ jobs:
pr_url: ${{ inputs.pr_url || '' }}
dry_run: ${{ inputs.dry_run || '' }}
force_review: ${{ inputs.force_review || '' }}
# Forward the LSP pilot A/B leg (empty for event triggers). 'none'/'' both
# mean today's behaviour on the reusable side.
lsp_pilot_variant: ${{ inputs.lsp_pilot_variant || '' }}
# NOTE: lsp_pilot_variant forwarding removed — the pinned reusable
# pr-review.yml@pr-review/next does not (yet) declare that input, so passing
# it fails workflow validation → startup_failure on every review dispatch
# (fleet-wide review outage, #1031/#1034 caller-vs-channel skew). Re-add
# this line only after the input is promoted to the pr-review/next reusable.
# The workflow_dispatch input above is retained (harmless, unused for now).
secrets: inherit
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,13 @@ def check_trigger(fails: list[str]) -> None:
job = _review_job(doc)
with_block = job.get("with") or {}
forwarded = str(with_block.get(INPUT, ""))
if not forwarded:
fails.append(f"{TRIGGER}: review job does not forward {INPUT} to the reusable (AC #5)")
elif f"inputs.{INPUT}" not in forwarded:
# Forwarding is intentionally absent while the pinned pr-review/next reusable
# does not yet declare lsp_pilot_variant (caller-vs-channel input skew — passing
# an undeclared input to a reusable is a workflow-validation error that causes
# startup_failure on every review dispatch). Absent forwarding is accepted here;
# when the input is promoted to the pr-review/next channel, re-add the with:
# line in pr-review-trigger.yml and tighten this check back to require it.
if forwarded and f"inputs.{INPUT}" not in forwarded:
fails.append(
f"{TRIGGER}: forwarded {INPUT} does not reference inputs.{INPUT} (got: {forwarded!r})"
)
Expand All @@ -165,7 +169,8 @@ def main() -> int:
return 1

print("PASS: pr-review.yml exports the capture gate + variant and gates LSP wiring; "
"pr-review-trigger.yml declares and forwards lsp_pilot_variant")
"pr-review-trigger.yml declares lsp_pilot_variant (forwarding absent while "
"pinned channel lacks the input — see check_trigger comments)")
return 0


Expand Down
Loading