Skip to content

fix(pr-review): stop forwarding lsp_pilot_variant to the pinned reusable (restore reviews) - #1051

Closed
don-petry wants to merge 2 commits into
mainfrom
fix/pr-review-trigger-lsp-input-skew
Closed

don-petry wants to merge 2 commits into
mainfrom
fix/pr-review-trigger-lsp-input-skew

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Fleet-wide PR-review outage — root cause + fix

Symptom: every PR-review dispatch has startup_failured since ~03:16 UTC today; no PR can get a code-owner (donpetry-bot) review. Only the PR Review Agent — Trigger workflow is affected (all other workflows healthy).

Root cause: #1031/#1034 (a492721ad) added lsp_pilot_variant: ${{ inputs.lsp_pilot_variant || '' }} to the with: block that calls pr-review.yml@pr-review/next. That channel-pinned reusable (last updated 2026-06-21) does not declare that input — passing an undeclared input to a reusable is a workflow-file validation error → startup_failure on every dispatch (repository_dispatch / workflow_dispatch / check_suite). Caller-vs-channel skew.

Fix: remove only the forwarding line. The workflow_dispatch input definition is retained (valid type: choice, harmless while unused). Re-add the forwarding once the input is promoted to the pr-review/next reusable (then #1031's LSP-pilot A/B leg works end-to-end).

⚠️ Merge note

This restores the review pipeline, but merging it requires the very review gate it fixes — so it needs an admin-merge / direct authorization to break the cycle. CI on this PR should be green; the code-owner review will keep failing until this lands.

🤖 Generated with Claude Code

Fleet-wide PR-review outage: pr-review-trigger.yml passes lsp_pilot_variant to
pr-review.yml@pr-review/next, but that channel-pinned reusable (last updated
2026-06-21) does not declare the input. Passing an undeclared input to a
reusable is a workflow-file validation error, so EVERY review dispatch
startup_failed (repository_dispatch / workflow_dispatch / check_suite) since the
#1031/#1034 caller change landed (~03:16 UTC) — no PR could be reviewed.

Remove only the with: forwarding line to restore reviews immediately. The
workflow_dispatch input definition is retained (harmless, unused). Re-add the
forwarding once the input is promoted to the pr-review/next reusable (then the
#1031 LSP-pilot A/B leg works end-to-end).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HUhVsBbihbTjVvbcVf1WuU
Copilot AI review requested due to automatic review settings July 3, 2026 14:03
@don-petry
don-petry requested a review from a team as a code owner July 3, 2026 14:03
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 072a6bbc-346a-4c69-9e0f-05e721e98438

📥 Commits

Reviewing files that changed from the base of the PR and between 3a971b6 and 2da40b3.

📒 Files selected for processing (2)
  • .github/workflows/pr-review-trigger.yml
  • tests/dev-lead/integration/test_pr_review_lsp_pilot_plumbing.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr-review-trigger-lsp-input-skew

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the fleet’s PR-review trigger workflow by removing forwarding of an undeclared input (lsp_pilot_variant) to the channel-pinned reusable (pr-review.yml@pr-review/next), which was causing workflow validation failures and startup_failure on every dispatch.

Changes:

  • Removed lsp_pilot_variant from the with: inputs passed to the pinned reusable to avoid “undeclared input” validation errors.
  • Left the workflow_dispatch input definition in place (documented as currently unused) so it can be re-enabled once the reusable declares the input.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) July 3, 2026 14:07
@don-petry
don-petry disabled auto-merge July 3, 2026 14:08
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 3, 2026 14:08
@don-petry

Copy link
Copy Markdown
Collaborator Author

Closing per maintainer decision to take a different fix path (not admin-merging a revert). Root cause + the 1-line fix are documented here for reference if needed. The review-pipeline outage (pr-review-trigger.yml forwarding lsp_pilot_variant to the pr-review/next reusable that doesn't declare it) is still open.

@don-petry don-petry closed this Jul 3, 2026
auto-merge was automatically disabled July 3, 2026 14:17

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants