Repository navigation
feat(canary-rings): onboard the 6 #482 reusables into the registry (#1036) - #1044
Conversation
…1036) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@donpetry-bot please review — config-only registry population (#1036), unblocks fleet-wide evaluate-all for the 6 #482 reusables. No tags/releases touched. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe canary-ring configuration file is reformatted into explicit multi-line JSON, and each agent's gate block is standardized: benign_failure_classes allowlists are replaced or set to empty arrays, and a new gate._benign_note field is introduced across dev-lead and the other listed agents, while transition and control settings remain unchanged. ChangesCanary Ring Configuration Update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #1044 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
|
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
Pull request overview
This PR expands the canary rollout registry (standards/canary-rings.json) to include the six .github-hosted reusables from #482 so the fleet-wide canary automation (scripts/canary-rollout.sh evaluate-all) can evaluate (and eventually promote) them alongside dev-lead.
Changes:
- Adds registry entries for
agent-shield,auto-rebase,dependency-audit,dependabot-automerge,dependabot-rebase, andpr-review-mention, with explicit ring memberships and #548 gate defaults. - Extends the
dev-leadentry with explicit per-transition gate knobs and keeps/expands the benign-failure-class allowlist. - Reformats
org_infra_repos(and the JSON overall) for readability/consistency.
There was a problem hiding this comment.
Code Review
This pull request formats standards/canary-rings.json and introduces several new workflow configurations, including agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, and pr-review-mention. The review feedback points out that the "soak_start_ring": "ring0" property in the dependabot-rebase configuration is not supported by the orchestrator scripts and should be removed if it is dead configuration.
| }, | ||
| "soak_start_ring": "ring0" |
There was a problem hiding this comment.
The property "soak_start_ring": "ring0" is defined here, but it is not referenced or supported anywhere in scripts/canary-rollout.sh or scripts/lib/canary-rollout.sh. The orchestrator script will still evaluate the next->ring0 transition. If this is dead configuration, it should be removed to avoid confusion.
}
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1036) (#1044) canary-rings.json contained only dev-lead, so the fleet-wide `evaluate-all` covered nothing else and the #482 rollout couldn't be completed by the automation. Add the six .github-hosted reusables (agent-shield, auto-rebase, dependency-audit, dependabot-automerge, dependabot-rebase, pr-review-mention). Ring assignment is EXPLICIT (not host-relative): host is petry-projects/.github but next=.github-private, ring0=.github, ring1=TalkTerm+bmad, stable="*" (the org-owner decision from #870 — inverted from the $host/$org_infra default). dependabot-rebase has no .github-private caller → soak_start_ring: ring0. Gate = the #548 defaults (copied from dev-lead); benign list empty (these have been clean). run_workflow = each caller's workflow display name. dev-lead stalled on #1036; added per the monitor unblock mandate. Config only — no channel tags moved, no releases cut. Refs #1036, #1025, #548. Co-authored-by: Claude Code Bot <bot@petry-projects>
…1045 part a) (#1047) The agent workflow_dispatch choice was hardcoded to [dev-lead], so manual evaluate/promote/rollback couldn't target the 6 #482 reusables now in the registry. List all 7 so they can be evaluated + promoted. (The gated SCHEDULED auto-promote — #1045 part b, decision A — remains for dev-lead.) Refs #1045, #1044. Co-authored-by: Claude Code Bot <bot@petry-projects>



Populates
standards/canary-rings.jsonwith the six.github-hosted #482 reusables so the fleet-wideevaluate-allactually covers them (the registry was dev-lead-only, so the automation couldn't complete their rollout).Ring assignment is explicit, not host-relative (per #870): host is
petry-projects/.githubbutnext=.github-private,ring0=.github,ring1=TalkTerm+bmad,stable=*.dependabot-rebasehas no.github-privatecaller →soak_start_ring: ring0. Gate = #548 defaults (from dev-lead);run_workflow= each caller's display name.dev-lead stalled on #1036; added per the monitor unblock mandate. Config-only — no tags moved, no releases cut.
Closes #1036. Refs #1025, #548.
🤖 Generated with Claude Code
Summary by CodeRabbit