Skip to content

Populate canary-rings.json with the 6 #482 reusables (registry is dev-lead-only → evaluate-all covers nothing else) #1036

Closed

Description

@don-petry

#1026 fixed evaluate-all (P1) + client-id auth ✅ — verified live: the 02:38Z scheduled run minted the token via client-id and ran evaluate-all. But it only evaluated dev-lead, because standards/canary-rings.json contains only dev-lead. The 6 #482 reusables (rolled out manually via the now-retired bridge, never onboarded into the registry) are absent — so the automation cannot see or complete their rollout. This is the last thing blocking real fleet automation.

Add these 6 to canary-rings.json (host petry-projects/.github, cross-repo)

All share the same ring topology; use dev-lead's existing entry as the schema template (members/reusable/run_workflow/gate with #548 per-transition knobs). Rings:

  • next (order 0): petry-projects/.github-private
  • ring0 (order 1): petry-projects/.github
  • ring1 (order 2): petry-projects/TalkTerm, petry-projects/bmad-bgreat-suite
  • stable (order 3): "*" (broad fleet)
agent reusable run_workflow notes
agent-shield .github/workflows/agent-shield-reusable.yml agent-shield.yml at stable (done)
dependency-audit …/dependency-audit-reusable.yml dependency-audit.yml at stable (done)
auto-rebase …/auto-rebase-reusable.yml auto-rebase.yml at ring1; stable baseline is acec8959 (not 376a4fcb)
dependabot-automerge …/dependabot-automerge-reusable.yml dependabot-automerge.yml at ring1
dependabot-rebase …/dependabot-rebase-reusable.yml dependabot-rebase.yml at ring1; no .github-private caller → set soak_start_ring: ring0 (or equivalent)
pr-review-mention …/pr-review-mention-reusable.yml pr-review-mention.yml at ring1; candidate is v2.1.1 (93bfca45); the pre-fix v2.1.0 loop failure predates its cut

Once added, the next evaluate-all will report all 7, and the 4 at ring1 can be carried to stable by command=promote.

Related (P2 follow-up, dev-lead-specific)

dev-lead's evaluate shows cum_fail=68 benign=0 → the benign_match allowlist is running but dev-lead's known-benign classes (#864 Dependabot-context dispatch; fix-review git-push-permission) aren't configured, so it stays BLOCKED. Add those classes to dev-lead's gate.benign (or equivalent) so it can advance. See #1005.

Refs #1025/#1026 (P1/P2), #548, #1005 (dev-lead onboarding), #1008 (idea-pipeline onboarding — separate).

Activity

  1. don-petry commented on Jul 3, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #1036 — Populate canary-rings.json with the 6 #482 reusables

    Scope

    Register the 6 #482 cross-repo reusables (host petry-projects/.github) in standards/canary-rings.json using dev-lead's entry as the schema template, so evaluate-all sees all 7 agents.

    Implementation Checklist

    • Add 6 agents to standards/canary-rings.json: agent-shield, dependency-audit, auto-rebase, dependabot-automerge, dependabot-rebase, pr-review-mention
    • Each: host=petry-projects/.github, reusable=.github/workflows/<name>-reusable.yml, run_workflow=<name>.yml
    • Shared ring topology: next→.github-private (order 0), ring0→.github (order 1), ring1→TalkTerm+bmad-bgreat-suite (order 2), stable→* (order 3)
    • Shared gate with feat: implement issue #545 — Compliance: non-stub-dependency-audit.yml #548 per-transition knobs (incl. waive_sample_if_no_caller: true on next->ring0, which covers dependabot-rebase's missing .github-private caller — the "soak starts at ring0" note)

    Tests to Write (tests/canary_rollout.bats)

    Notes on scope boundaries

    • Per-agent notes about candidate SHAs / stable baselines (e.g. auto-rebase acec8959, pr-review-mention v2.1.1) are channel-tag (git) state, not registry fields — out of scope for this JSON change.
    • The P2 dev-lead benign classes are already present in the file — not re-touched here.

    Test Command

    bats tests/canary_rollout.bats (+ bash .dev-lead/scripts/dev-lead-lint.sh)

  2. don-petry commented on Jul 3, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    Test Results

    bats tests/canary_rollout.bats  →  57/57 ok  (was 51; +6 new)
    
    ok 52 canary-rings.json: all 6 #482 reusables are registered (7 agents incl. dev-lead)
    ok 53 canary-rings.json: each #482 reusable has host .github + right reusable path + run_workflow
    ok 54 canary-rings.json: #482 reusables share the ring topology (next=.github-private, ring0=.github, ring1 pair, stable=*)
    ok 55 orchestrator: resolve_members for a #482 cross-repo reusable (next=.github-private, ring0=.github, stable=*)
    ok 56 canary-rings.json: #482 reusables carry the #548 per-transition gate knobs
    ok 57 orchestrator: evaluate-all reports all 7 registered agents (dev-lead + the 6 #482)
    
    bats tests/test_bootstrap_new_repo.bats  →  18/18 ok (consumes the ring SoT; unaffected)
    bash .dev-lead/scripts/dev-lead-lint.sh  →  all checks passed (shellcheck 85 files + agent frontmatter)
    

    Files Changed

    Notes

    • Deliberate topology inversion (documented in a _topology_note): for these cross-repo reusables the reusable is hosted in petry-projects/.github, but the rollout is canaried in petry-projects/.github-private first (next, order 0 — the caller-stub/automation repo), then the host (ring0). Members are written as literal repos (not the $host/$org_infra tokens) so the inversion is explicit and unambiguous.
    • dependabot-rebase has no .github-private caller → its next tier has zero callers, so the existing waive_sample_if_no_caller: true on next->ring0 waives the fresh sample (dwell-only) — i.e. the soak effectively starts at ring0, the "soak_start_ring: ring0 (or equivalent)" ask. No new field needed.
    • Out of scope (git/tag state, not registry): per-agent candidate SHAs / stable baselines (auto-rebase acec8959, pr-review-mention v2.1.1 93bfca45) live as channel tags — channel_commit derives them; the registry only defines topology + gate knobs.
    • P2 (dev-lead benign classes): already present in the file (dependabot-context-dispatch, fix-review-git-push-permission) — left untouched, as it's a separate dev-lead-specific concern (Onboard dev-lead into Release_Manager automation (+ resolve ring1 no-signal blocker) #1005).
    • The 6 new agents carry no benign_failure_classes (none known); the gate code handles absence via // [].
    • Next scheduled evaluate-all will now report all 7 agents; the 4 sitting at ring1 can be carried to stable via command=promote.
  3. added a commit that references this issue on Jul 3, 2026
  4. added 18 commits that reference this issue on Aug 2, 2026
  5. added a commit that references this issue on Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickupenhancementFeature requests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions