Repository navigation
feat(widget): add Spanish locale - #355
Conversation
anurag629
left a comment
There was a problem hiding this comment.
Thanks @piyusshhjangid, this reads well, with proper accents and opening ¿/¡, and unreadCount is included. Build, typecheck, lint, the locale tests, coverage and the docs check pass on my side, and it builds to dist/locales/es.js.
One fix: packages/widget/src/locales/es.ts:33, unreadCount. '{count} mensajes sin leer' comes out as "1 mensajes sin leer" when there's one reply, and the widget has no plural rules. The English string avoids the plural for that reason ("1 unread", "3 unread"). Please use '{count} sin leer'.
About the failing "Linked issue is assigned to the author" check: that's the Part of #55 problem from #351, and #354 fixes it. You're assigned to #55, so it won't hold this PR up.
On French: you're at two open issues with Spanish and #335 (now merged, so that one frees up). Once this is merged, comment on #55 for French, and if nobody has taken it by then, it's yours.
anurag629
left a comment
There was a problem hiding this comment.
Thanks @piyusshhjangid, that's it. The locale tests, lint and the docs check pass on my side with dev merged in, and it builds to dist/locales/es.js. The red claim check is the Part of #55 issue; #354 fixes it.
Summary
Part of #55
Adds a complete Spanish (
es) locale for the ChatCops widget, including Spanish accents, opening punctuation, and preserved placeholders. Adds Spanish to the widget internationalization docs and includes a patch changeset for@chatcops/widget.How I tested this
pnpm --filter @chatcops/widget buildpnpm --filter @chatcops/widget test— 368 tests passedpnpm --filter @chatcops/widget typechecknode scripts/check-doc-samples.mjs— 108 checked, 1 skippedgit diff --checkAI assistance
OpenAI Codex assisted with drafting the Spanish translations and implementing the locale. I reviewed the translations for natural wording and accuracy.