Skip to content

feat(widget): add Spanish locale - #355

Merged
anurag629 merged 3 commits into
codercops:devfrom
piyusshhjangid:codex/55-spanish-locale
Oct 27, 2026
Merged

anurag629 merged 3 commits into
codercops:devfrom
piyusshhjangid:codex/55-spanish-locale

Conversation

@piyusshhjangid

Copy link
Copy Markdown
Contributor

Summary

Part of #55

Adds a complete Spanish (es) locale for the ChatCops widget, including Spanish accents, opening punctuation, and preserved placeholders. Adds Spanish to the widget internationalization docs and includes a patch changeset for @chatcops/widget.

How I tested this

  • pnpm --filter @chatcops/widget build
  • pnpm --filter @chatcops/widget test — 368 tests passed
  • pnpm --filter @chatcops/widget typecheck
  • node scripts/check-doc-samples.mjs — 108 checked, 1 skipped
  • git diff --check

AI assistance

OpenAI Codex assisted with drafting the Spanish translations and implementing the locale. I reviewed the translations for natural wording and accuracy.

@anurag629 anurag629 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piyusshhjangid, this reads well, with proper accents and opening ¿/¡, and unreadCount is included. Build, typecheck, lint, the locale tests, coverage and the docs check pass on my side, and it builds to dist/locales/es.js.

One fix: packages/widget/src/locales/es.ts:33, unreadCount. '{count} mensajes sin leer' comes out as "1 mensajes sin leer" when there's one reply, and the widget has no plural rules. The English string avoids the plural for that reason ("1 unread", "3 unread"). Please use '{count} sin leer'.

About the failing "Linked issue is assigned to the author" check: that's the Part of #55 problem from #351, and #354 fixes it. You're assigned to #55, so it won't hold this PR up.

On French: you're at two open issues with Spanish and #335 (now merged, so that one frees up). Once this is merged, comment on #55 for French, and if nobody has taken it by then, it's yours.

@anurag629 anurag629 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @piyusshhjangid, that's it. The locale tests, lint and the docs check pass on my side with dev merged in, and it builds to dist/locales/es.js. The red claim check is the Part of #55 issue; #354 fixes it.

@anurag629
anurag629 merged commit 535e23a into codercops:dev Oct 27, 2026
4 of 5 checks passed
@anurag629 anurag629 added the hacktoberfest-accepted PR counts for Hacktoberfest label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PR counts for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants