Skip to content

ci: let the claim check accept "Part of #N" - #354

Open
anurag629 wants to merge 2 commits into
devfrom
ci/claim-check-part-of
Open

anurag629 wants to merge 2 commits into
devfrom
ci/claim-check-part-of

Conversation

@anurag629

Copy link
Copy Markdown
Member

The claim check only reads closing references (Closes #12), so a PR for one language of #55 had two bad options: write Closes #55 and close the translations issue for everyone, or write Part of #55 and fail the check. #351 hit exactly that.

This makes Part of #N count as a link when the PR has no closing references, with the same rule: the issue has to be assigned to the PR's author. CONTRIBUTING and the check's failure message say when to use it.

Tested the pattern with jq:

Description Linked
Part of #55 55
part of: #55 55
Closes #12 12
Fixes #3 and part of #55 3, 55
parts of #9 none

The workflow runs as pull_request_target, so the change takes effect for new PR events once it's on dev.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant