Skip to content

ml-dsa: Don't use tr pointer #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armfazh merged 2 commits into from
May 6, 2026
Merged

ml-dsa: Don't use tr pointer #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36c3af
sign/dilithium: hold tr by value in pk returned from Public() and New…
bshastry May 6, 2026
547aa42
sign/dilithium: don't use tr pointer
bwesterb May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sign/dilithium/mode2/internal/dilithium.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions sign/dilithium/mode3/internal/dilithium.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type PublicKey struct {
// Cached values
t1p [common.PolyT1Size * K]byte
A *Mat
tr *[TRSize]byte
tr [TRSize]byte
}

// PrivateKey is the type of Dilithium private keys.
Expand Down Expand Up @@ -119,7 +119,6 @@ func (pk *PublicKey) Unpack(buf *[PublicKeySize]byte) {
pk.A.Derive(&pk.rho)

// tr = CRH(ρ ‖ t1) = CRH(pk)
pk.tr = new([TRSize]byte)
h := sha3.NewShake256()
_, _ = h.Write(buf[:])
_, _ = h.Read(pk.tr[:])
Expand Down Expand Up @@ -235,7 +234,7 @@ func NewKeyFromSeed(seed *[common.SeedSize]byte) (*PublicKey, *PrivateKey) {
_, _ = h.Read(sk.tr[:])

// Finish cache of public key
pk.tr = &sk.tr
pk.tr = sk.tr

return &pk, &sk
}
Expand Down Expand Up @@ -475,7 +474,7 @@ func (sk *PrivateKey) Public() *PublicKey {
pk := &PublicKey{
rho: sk.rho,
A: &sk.A,
tr: &sk.tr,
tr: sk.tr,
}
sk.computeT0andT1(&t0, &pk.t1)
pk.t1.PackT1(pk.t1p[:])
Expand Down
7 changes: 3 additions & 4 deletions sign/dilithium/mode5/internal/dilithium.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions sign/mldsa/mldsa44/internal/dilithium.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions sign/mldsa/mldsa65/internal/dilithium.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions sign/mldsa/mldsa87/internal/dilithium.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading