Conversation
…KeyFromSeed Previously the PublicKey returned by (*PrivateKey).Public() and NewKeyFromSeed cached tr as a pointer aliasing sk.tr. As a result, any later mutation of sk.tr -- for example via a subsequent (*PrivateKey).Unpack on attacker-controlled bytes -- silently propagated into a pk that had already been returned to the caller. Switch both sites to a value copy. The returned pk now holds its own [TRSize]byte and is independent of subsequent changes to sk. Refs: #600 Edited in sign/dilithium/mode3/internal (master); regenerated to mode2/5 and sign/mldsa/{mldsa44,mldsa65,mldsa87} via go generate. A regression test (TestPublicTrIsIndependentOfPrivate) is added in the same place and propagates to all six internal packages.
5 tasks
rozbb
approved these changes
May 6, 2026
armfazh
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600