check --repair: flush pack writer in ArchiveChecker.finish() before dropping the index - #10072
Merged
ThomasWaldmann merged 1 commit intoAug 11, 2026
Merged
Conversation
…ropping the index During --repair, add_reference() re-adds chunks via repository.put(), which only buffers them in the pack writer. finish() then deleted the chunk index without flushing, so a buffered chunk survived to repository.close(), which asserts an empty buffer. Flush in finish() before deleting the index.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10072 +/- ##
==========================================
- Coverage 86.77% 84.54% -2.24%
==========================================
Files 98 98
Lines 17109 17134 +25
Branches 2591 2601 +10
==========================================
- Hits 14847 14486 -361
- Misses 1570 1964 +394
+ Partials 692 684 -8 ☔ View full report in Codecov by Harness. |
Comment on lines
2399
to
2400
| # drops the stale in-memory index, so the next repository access rebuilds it from the repo. | ||
| logger.info("Deleting chunk indexes in repository - next repository access will cause a rebuild.") |
Member
There was a problem hiding this comment.
this is something to look at later.
we should not kill the index, if we can avoid it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10055.
During
check --repair,add_reference()re-adds chunks viarepository.put(), which only buffers them in the pack writer.ArchiveChecker.finish()then deleted the chunk index without flushing, so a buffered chunk could survive torepository.close(), which asserts an empty buffer.This flushes the pack writer in
finish()before deleting the index. The test buffers a chunk in a repair-mode checker and checks thatfinish()stores it.