[SPARK-58088][INFRA] Extract checkout-and-sync pattern into composite GitHub Action#57187
Draft
nchammas wants to merge 2 commits into
Draft
[SPARK-58088][INFRA] Extract checkout-and-sync pattern into composite GitHub Action#57187nchammas wants to merge 2 commits into
nchammas wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extract the widely used checkout-and-sync pattern from various workflows into a reusable composite action. The pattern is used in about 16 different places across 3 workflow files.
We first do a normal checkout of the fork so that the latest version of the composite action is available. Using the composite action, we then checkout
apache/sparkand merge the changes as we currently do.There are other opportunities for extracting repeated build patterns. I will pursue them after proving out this refactoring, which perhaps offers the highest ROI since this pattern is the most highly used.
Why are the changes needed?
Having a reusable action will eliminate the need to manually keep so many chunks of build instructions in sync.
The "checkout fork, then checkout
apache/spark" approach introduced here is different from the past attempts made to factor out repeated build steps in #36924 and #56204.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The CI build associated with this PR will serve as the test.
Was this patch authored or co-authored using generative AI tooling?
I wrote this with assistance from GitHub Copilot.