[SPARK-39532][INFRA] Move checkout and sync steps into re-usable action#36924
[SPARK-39532][INFRA] Move checkout and sync steps into re-usable action#36924EnricoMi wants to merge 2 commits into
Conversation
|
@HyukjinKwon here is some first simplification of the |
1d9577d to
7bb761f
Compare
|
Can one of the admins verify this patch? |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks nice. LGTM if it works
| git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' commit -m "Merged commit" --allow-empty | ||
|
|
||
| branding: | ||
| icon: 'check-circle' |
There was a problem hiding this comment.
quick question: what is this?
There was a problem hiding this comment.
This is defines the icon of the action for UI and marketplace purposes, for instance the blue circle with the triangle at https://github.com/marketplace/actions/checkout
Not sure if this is required, does not make much sense if action is not published.
|
This is not applicable to Apache Spark CI as it first checksout Spark repo, then the fork repo, while this action (until merged into upstream repo) only becomes available after the sync step, which is main part of the composite action. In other words, this action cannot be executed until it has been merged into master. This makes it also difficult to contribute to. |
|
uhoh, right. thanks for explanation though :-). |
What changes were proposed in this pull request?
Steps "Checkout Spark repository" and "Sync the current branch with the latest in Apache Spark" are defined 9 times in
build-and-test.yml. This moves these two steps into a composite action that is than reused.Why are the changes needed?
Simplifies workflow file and reduces code duplication.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested in fork CI.