Issue #8294 : Fix the Select Values checks and make the default lint … - #8307
Merged
Merged
Conversation
… lint rules usable Select Values applies its tabs in order, each to the row the one before it produced, but check() compared all of them to the incoming row. A field renamed on "Select & Alter" was reported missing by the Metadata and Remove tabs, which only ever see the new name. Selecting the same field twice is how a value is copied under a second name, so the duplicate check now counts the names fields leave under. Two fields leaving under one name still is. Hop's check() methods were written for the Verify button and work from the design-time row stream. The linter repeated them unprompted at whatever severity the transform picked, with no rule able to say otherwise. A new `type: native` rule classifies them and the core pack reports them at warning; naming-scheme remarks come through the same door. The rest is the default rules meeting real projects: - TRANS-002 and WORKFLOW-002 reported on the file, so the warning could not name the transform it was about. They now report on the element. A file holding a single transform is no longer an orphan, and neither is one whose hops are disabled: that is what STRUCT-003 asks, and it ships off. - SEC-002 and SEC-003 matched any field merely containing "token" or "secret", at any type, putting three hardcoded-secret errors on every Token Replacement transform.
Contributor
|
Gemini Flash 3.8 on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rules usable
Select Values applies its tabs in order, each to the row the one before it produced, but check() compared all of them to the incoming row. A field renamed on "Select & Alter" was reported missing by the Metadata and Remove tabs, which only ever see the new name. Selecting the same field twice is how a value is copied under a second name, so the duplicate check now counts the names fields leave under. Two fields leaving under one name still is.
Hop's check() methods were written for the Verify button and work from the design-time row stream. The linter repeated them unprompted at whatever severity the transform picked, with no rule able to say otherwise. A new
type: nativerule classifies them and the core pack reports them at warning; naming-scheme remarks come through the same door.The rest is the default rules meeting real projects:
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.