Skip to content

Issue #8294 : Fix the Select Values checks and make the default lint … - #8307

Merged
mattcasters merged 1 commit into
apache:mainfrom
bamaer:8294
Sep 10, 2026
Merged

mattcasters merged 1 commit into
apache:mainfrom
bamaer:8294

Conversation

@bamaer

@bamaer bamaer commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

…rules usable

Select Values applies its tabs in order, each to the row the one before it produced, but check() compared all of them to the incoming row. A field renamed on "Select & Alter" was reported missing by the Metadata and Remove tabs, which only ever see the new name. Selecting the same field twice is how a value is copied under a second name, so the duplicate check now counts the names fields leave under. Two fields leaving under one name still is.

Hop's check() methods were written for the Verify button and work from the design-time row stream. The linter repeated them unprompted at whatever severity the transform picked, with no rule able to say otherwise. A new type: native rule classifies them and the core pack reports them at warning; naming-scheme remarks come through the same door.

The rest is the default rules meeting real projects:

  • TRANS-002 and WORKFLOW-002 reported on the file, so the warning could not name the transform it was about. They now report on the element. A file holding a single transform is no longer an orphan, and neither is one whose hops are disabled: that is what STRUCT-003 asks, and it ships off.
  • SEC-002 and SEC-003 matched any field merely containing "token" or "secret", at any type, putting three hardcoded-secret errors on every Token Replacement transform.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

… lint rules usable

Select Values applies its tabs in order, each to the row the one before it
produced, but check() compared all of them to the incoming row. A field
renamed on "Select & Alter" was reported missing by the Metadata and Remove
tabs, which only ever see the new name. Selecting the same field twice is
how a value is copied under a second name, so the duplicate check now counts
the names fields leave under. Two fields leaving under one name still is.

Hop's check() methods were written for the Verify button and work from the
design-time row stream. The linter repeated them unprompted at whatever
severity the transform picked, with no rule able to say otherwise. A new
`type: native` rule classifies them and the core pack reports them at
warning; naming-scheme remarks come through the same door.

The rest is the default rules meeting real projects:

- TRANS-002 and WORKFLOW-002 reported on the file, so the warning could not
  name the transform it was about. They now report on the element. A file
  holding a single transform is no longer an orphan, and neither is one
  whose hops are disabled: that is what STRUCT-003 asks, and it ships off.
- SEC-002 and SEC-003 matched any field merely containing "token" or
  "secret", at any type, putting three hardcoded-secret errors on every
  Token Replacement transform.
@mattcasters

Copy link
Copy Markdown
Contributor

Gemini Flash 3.8 on high could only find silly things so I'm merging.

@mattcasters
mattcasters merged commit 23a3df7 into apache:main Sep 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants