Repository navigation
Consolidate core_integration/datasource and rename parquet_source --> parquet_integration - #18226
Merged
Merged
Conversation
… parquet_integration
github-actions
Bot
added
core
Contributor
Author
|
Thanks @Jefffrey |
tschwarzinger
pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
… parquet_integration (apache#18226) ## Which issue does this PR close? - related to apache#11210 ## Rationale for this change Running the following command ```shell cargo test --test csv_schema_fix_test ``` Results in a 201 mb binary (and requires linking, etc) for only a few tests ```shell du -s -h target/debug/deps/csv_schema_fix_test-48507d40c6598e82 201M target/debug/deps/csv_schema_fix_test-48507d40c6598e82 ``` Let's combine that into the existing core integration test to save CI runner space and time Also, I have been confused why the parquet integration tests are named `parquet_source` (I think it is meant to mirror `ParquetSource` which is confusing) so let's change that to something more discoverable ## What changes are included in this PR? 1. Consolidate core_integration/datasource 2. rename `parquet_source` --> `parquet_integration` ## Are these changes tested? It is only tests. You can run the tests in the new location via ```shell cargo test --test core_integration -- csv ``` ## Are there any user-facing changes? No, this is all internal test rearrangement
EeshanBembi
pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
… parquet_integration (apache#18226) ## Which issue does this PR close? - related to apache#11210 ## Rationale for this change Running the following command ```shell cargo test --test csv_schema_fix_test ``` Results in a 201 mb binary (and requires linking, etc) for only a few tests ```shell du -s -h target/debug/deps/csv_schema_fix_test-48507d40c6598e82 201M target/debug/deps/csv_schema_fix_test-48507d40c6598e82 ``` Let's combine that into the existing core integration test to save CI runner space and time Also, I have been confused why the parquet integration tests are named `parquet_source` (I think it is meant to mirror `ParquetSource` which is confusing) so let's change that to something more discoverable ## What changes are included in this PR? 1. Consolidate core_integration/datasource 2. rename `parquet_source` --> `parquet_integration` ## Are these changes tested? It is only tests. You can run the tests in the new location via ```shell cargo test --test core_integration -- csv ``` ## Are there any user-facing changes? No, this is all internal test rearrangement
This was referenced Oct 16, 2026
bvolpato
pushed a commit
to bvolpato/datafusion
that referenced
this pull request
Oct 16, 2026
…26422) ## Which issue does this PR close? This follows the same rationale as earlier PRs like - apache#10588 - apache#11831 - apache#18226 - apache#26419 ## Rationale for this change Each `.rs` file directly in `datafusion/core/tests` becomes its own test binary. In this case, the standalone `tpcds_planning` binary requires **390 MB** (408,695,296 bytes, as reported by `du -h`) on my machine (macOS, aarch64) ```shell cargo test -p datafusion --test tpcds_planning --no-run ``` The binary was added in - apache#4719 ## What changes are included in this PR? Move `datafusion/core/tests/tpcds_planning.rs` to `datafusion/core/tests/sql/tpcds_planning.rs` and register it in `sql/mod.rs`, so it is built as part of `core_integration`. Size of `core_integration` (debug build): | | bytes | |---|---| | before | 457,595,344 | | after | 458,314,960 (+703 KB) | So this saves creating a ~390 MB binary at a cost of ~703 KB in `core_integration`. ## What is the testing strategy for this PR? CI ## Are there any user-facing changes? No, developer productivity / CI efficiency Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
final link failed: No space left on device#11210Rationale for this change
Running the following command
cargo test --test csv_schema_fix_testResults in a 201 mb binary (and requires linking, etc) for only a few tests
Let's combine that into the existing core integration test to save CI runner space and time
Also, I have been confused why the parquet integration tests are named
parquet_source(I think it is meant to mirrorParquetSourcewhich is confusing) so let's change that to something more discoverableWhat changes are included in this PR?
parquet_source-->parquet_integrationAre these changes tested?
It is only tests. You can run the tests in the new location via
cargo test --test core_integration -- csvAre there any user-facing changes?
No, this is all internal test rearrangement