Repository navigation
Minor: consolidate path_partition test into core_integration - #11831
Merged
Merged
Conversation
core_integrationpath_partition test into core_integration
alamb
force-pushed
the
alamb/consolidate
branch
from
August 5, 2024 20:31
e4bc409 to
bef4044
Compare
Contributor
Author
|
Thanks @lewiszlw |
This was referenced Oct 16, 2026
bvolpato
pushed a commit
to bvolpato/datafusion
that referenced
this pull request
Oct 16, 2026
…26422) ## Which issue does this PR close? This follows the same rationale as earlier PRs like - apache#10588 - apache#11831 - apache#18226 - apache#26419 ## Rationale for this change Each `.rs` file directly in `datafusion/core/tests` becomes its own test binary. In this case, the standalone `tpcds_planning` binary requires **390 MB** (408,695,296 bytes, as reported by `du -h`) on my machine (macOS, aarch64) ```shell cargo test -p datafusion --test tpcds_planning --no-run ``` The binary was added in - apache#4719 ## What changes are included in this PR? Move `datafusion/core/tests/tpcds_planning.rs` to `datafusion/core/tests/sql/tpcds_planning.rs` and register it in `sql/mod.rs`, so it is built as part of `core_integration`. Size of `core_integration` (debug build): | | bytes | |---|---| | before | 457,595,344 | | after | 458,314,960 (+703 KB) | So this saves creating a ~390 MB binary at a cost of ~703 KB in `core_integration`. ## What is the testing strategy for this PR? CI ## Are there any user-facing changes? No, developer productivity / CI efficiency Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Each individual .rs file in the
testsdirectory results in a new test binary which means:What changes are included in this PR?
Consolidate the
path_partitiontest into thecore_integrationtest to make testing more efficientAre these changes tested?
By CI. I also tested locally
You can see the tests run like this:
Are there any user-facing changes?