Repository navigation
chore: Reduce syscalls in metrics update logic - #2940
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
============================================
+ Coverage 56.12% 59.61% +3.48%
- Complexity 976 1379 +403
============================================
Files 119 167 +48
Lines 11743 15430 +3687
Branches 2251 2550 +299
============================================
+ Hits 6591 9198 +2607
- Misses 4012 4946 +934
- Partials 1140 1286 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
marked this pull request as ready for review
December 19, 2025 00:14
mbutrovich
approved these changes
Dec 19, 2025
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
I suspect poll iterations will still be quick, right? We don't have to worry too much about super slow iterations delaying metrics updates? Thanks @andygrove!
Member
Author
The worst case is that the UI updates infrequently during execution, but the final metrics will always be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Reduce syscalls by 99% when checking whether it is time to update metrics (check once per 100 polls instead of on every poll).
What changes are included in this PR?
How are these changes tested?