Skip to content

Use coarse time when calculating metrics refresh interval #1381

Closed as not planned

Description

@andygrove

What is the problem the feature request solves?

See comment at #1329 (comment)

Describe the potential solution

No response

Additional context

No response

Activity

  1. added this to the 0.7.0 milestone on Feb 8, 2025
  2. modified the milestones: 0.7.0, 0.8.0 on Mar 3, 2025
  3. modified the milestones: 0.8.0, 0.9.0 on Apr 17, 2025
  4. removed this from the 0.9.0 milestone on Jun 5, 2025
  5. andygrove commented on Sep 28, 2026

    @andygrove
    MemberAuthor

    Closing this, since the loop it was about is gone. The interval check's Instant::now() used to run on every spin of the busy-poll loop in executePlan. #2940 cut that to once per 100 polls, and #6219 replaced the busy loop with one that parks while it waits on native I/O. What's left is one clock read per output batch and one per pending poll. Each of those sits next to a JNI handoff, a pull from the JVM or a wake-up that costs far more than the read. Most DataFusion operators also read the clock twice per batch for their own metrics, and coarsetime can't reach those, so switching this one call would add a dependency without a measurable gain. Happy to reopen if a profile says otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions