Skip to content

[EPIC] Improve Comet Native writer #2967

Open

Description

@comphead

What is the problem the feature request solves?

This epic to track Comet native writer issues

Additional tests which had to be ignored for spark 4 :

  • ctas with union
  • SPARK-48817: test multi inserts

Describe the potential solution

No response

Additional context

No response

Activity

  1. coderfender commented on Jan 31, 2026

    @coderfender
    Contributor

    Creating new issues and tagging in this EPIC to address failing spark tests

  2. coderfender commented on Feb 6, 2026

    @coderfender
    Contributor

    I think we can classify test failures fall into 3 main categories :

    Empty file/dir creation

    1. empty file should be skipped while write to file
    2. SPARK-33901: ctas should not change table's schema
    3. SPARK-37160: CREATE TABLE AS SELECT with CHAR_AS_VARCHAR

    Insert overwrite bugs

    1. SPARK-29174 Support LOCAL in INSERT OVERWRITE DIRECTORY
    2. SPARK-38336 INSERT INTO with default columns
    3. SPARK-38811 INSERT INTO on ALTER TABLE ADD COLUMNS
    4. SPARK-43071: INSERT INTO from non-projection queries
    5. Insert overwrite table command should output correct schema: basic

    Other

    1. parquet timestamp conversion (timestamp96)
    2. INSERT INTO TABLE - complex type but different names
    3. Write Spark version into Parquet metadata
    4. write path implements onTaskCommit API correctly
  3. coderfender commented on Feb 6, 2026

    @coderfender
    Contributor

    linking newly created issues with the EPIC for lineage tracking

    Empty file/dir creation

    empty file should be skipped while write to file
    #3417

    SPARK-33901: ctas should not change table's schema
    #3418

    SPARK-37160: CREATE TABLE AS SELECT with CHAR_AS_VARCHAR
    #3419

    Insert overwrite bugs

    SPARK-29174 Support LOCAL in INSERT OVERWRITE DIRECTORY
    #3420

    SPARK-38336 INSERT INTO with default columns
    #3421

    SPARK-38811 INSERT INTO on ALTER TABLE ADD COLUMNS
    #3422

    SPARK-43071: INSERT INTO from non-projection queries
    #3423

    Insert overwrite table command should output correct schema: basic
    #3424

    Other

    parquet timestamp conversion (timestamp96)
    #3425

    INSERT INTO TABLE - complex type but different names
    #3426

    Write Spark version into Parquet metadata
    #3427

    write path implements onTaskCommit API correctly
    #3428

    ##Spark 4x tests

    ctas with union
    #3429

    SPARK-48817: test multi insert
    #3430

  4. comphead commented on Feb 16, 2026

    @comphead
    ContributorAuthor

    Here test suites that Spark run for the writer

      Core DataFrame Writer Test Suites
    
      DataFrameReaderWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala:145
      DataFrameWriterV2Suite - sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala:44
      DataFrameSuite - sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala:60
      DataFrameCallbackSuite - sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala:37
    
      Java Test Suites
    
      JavaDataFrameReaderWriterSuite - sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java:32
      JavaDataFrameWriterV2Suite - sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameWriterV2Suite.java:35
    
      Format-Specific Writer Test Suites
    
      FileFormatWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala:24
      FileWriterFactorySuite - sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/FileWriterFactorySuite.scala:29
      JDBCWriteSuite - sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala:39
    
      Partitioning and Bucketing Writer Test Suites
    
      PartitionedWriteSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/PartitionedWriteSuite.scala:50
      BucketedWriteSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala:44
      BucketedWriteWithoutHiveSupportSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedWriteSuite.scala:35
    
      V1/V2 Write Command Test Suites
    
      V1WriteCommandSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/V1WriteCommandSuite.scala:128
      V1WriteFallbackSuite - sql/core/src/test/scala/org/apache/spark/sql/connector/V1WriteFallbackSuite.scala:45
      SaveIntoDataSourceCommandSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommandSuite.scala:26
    
      Insert and Save/Load Test Suites
    
      InsertSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:59
      SaveLoadSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala:32
      CreateTableAsSelectSuite - sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala:30
    
      Streaming Writer Test Suites
    
      DataStreamReaderWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala:113
      FileStreamSinkV1Suite - sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala:707
      FileStreamSinkV2Suite - sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala:758
      ForeachWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterSuite.scala:33
      PythonForeachWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonForeachWriterSuite.scala:35
    
      Other Writer Test Suites
    
      ArrowWriterSuite - sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowWriterSuite.scala:2
    

    Trying to create a separate pipeline with writer enabled to run those tests

  5. Shekharrajak commented on Feb 25, 2026

    @Shekharrajak
    Contributor

    We can consider this feature to be available in native writer #3595 - please have a look.

  6. comphead commented on Feb 25, 2026

    @comphead
    ContributorAuthor

    We can consider this feature to be available in native writer #3595 - please have a look.

    For Iceberg I'm not sure tbh, as iceberg-rs should have its own writer afaik, @mbutrovich please confirm

  7. Shekharrajak commented on Mar 21, 2026

    @Shekharrajak
    Contributor

    Please have a look : apache/iceberg-rust#2269 - this tracker can help in completing the iceberg native write support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions