Repository navigation
feat(vfs): enforce folder soft-delete cascade and selective restore - #286
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.02%
==========================================
Files 116 116
Lines 12336 12383 +47
==========================================
+ Hits 11261 11302 +41
- Misses 1075 1081 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
allenporter
force-pushed
the
feat/vfs-tree-invariants-and-restore
branch
3 times, most recently
from
October 18, 2026 22:01
155f082 to
e4ff53d
Compare
allenporter
force-pushed
the
feat/vfs-tree-invariants-and-restore
branch
from
October 18, 2026 22:13
e4ff53d to
affc7fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces consistent VFS folder soft-delete and restoration invariants (Part 1 of #248):
VirtualFileSystem.delete_node): Soft-deleting a folder cascades inactivation (is_active = 'N') across all active descendants so child items no longer appear in active directory listings, search results, or storage usage calculations.VirtualFileSystem.restore_node): Validates that the target node's parent directory exists and is active (raisingParentNotFoundotherwise), and when restoring a folder, reactivates only descendants that were inactivated by the folder cascade (preservingis_active = 'N'for items with their ownRecycleFileDOentry).(Permanent recycle bin purge and reference-counted blob cleanup are handled in #288.)