Repository navigation
feat(server): opportunistically prune expired recycle bin entries - #253
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 91.39% 91.42% +0.03%
==========================================
Files 116 116
Lines 12417 12427 +10
==========================================
+ Hits 11348 11361 +13
+ Misses 1069 1066 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 18, 2026
allenporter
force-pushed
the
fix/storage-cleanup-249
branch
from
October 18, 2026 20:03
4d5ddfe to
8a49453
Compare
allenporter
force-pushed
the
fix/storage-cleanup-249
branch
from
October 18, 2026 20:26
8a49453 to
cfef5cd
Compare
allenporter
changed the base branch from
main
to
feat/blob-refcount-and-derived-data-purge
October 18, 2026 20:26
allenporter
force-pushed
the
feat/blob-refcount-and-derived-data-purge
branch
2 times, most recently
from
October 18, 2026 21:05
db1f66d to
2420d89
Compare
allenporter
force-pushed
the
fix/storage-cleanup-249
branch
from
October 18, 2026 21:05
cfef5cd to
d03e889
Compare
allenporter
force-pushed
the
feat/blob-refcount-and-derived-data-purge
branch
from
October 18, 2026 21:44
2420d89 to
55501e4
Compare
allenporter
force-pushed
the
fix/storage-cleanup-249
branch
from
October 18, 2026 21:44
d03e889 to
847d763
Compare
allenporter
force-pushed
the
feat/blob-refcount-and-derived-data-purge
branch
3 times, most recently
from
October 18, 2026 22:15
3ac40fe to
68f3406
Compare
allenporter
force-pushed
the
fix/storage-cleanup-249
branch
from
October 18, 2026 22:23
847d763 to
fa843cf
Compare
allenporter
changed the base branch from
feat/blob-refcount-and-derived-data-purge
to
main
October 18, 2026 22:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #248.
Implements automatic 30-day retention pruning for the recycle bin directly inside
FileServiceandVirtualFileSystem:older_than_msfiltering toVirtualFileSystem.purge_recycleandFileService.purge_recycle.RECYCLE_RETENTION_MS = 30 * 24 * 3600 * 1000, 30 days) duringdelete_item,delete_items, andlist_recycle, reusing the reference-counted blob cleanup andNoteDeletedEventpublishing from feat(server): permanent recycle bin purge with ref-counted blob and derived data cleanup #288.