Skip to content

[SF_ACC][ui5-date-picker]: AXE errors about the ui5-date-picker dialog #9189

New issue
New issue
Closed
Closed
[SF_ACC][ui5-date-picker]: AXE errors about the ui5-date-picker dialog#9189
Assignees
unazko
Labels
1.24Medium PrioSF_ACCTOPIC BbugThis issue is a bug in the code
Milestone
1.24.8

Description

@ksblklu02
ksblklu02
opened on Jun 12, 2024

Bug Description

AXE tool has identified some ARIA issues and accessible name on the calendar dialog

  1. Month select dialog & date select dialog: ARIA dialog and alertdialog node should has an accessible name
image image
  1. Elements with an ARIA role that require child roles contain them
image
  1. Different "open picker" button should have unique aria-label, associated with ui5-date-picker accessibleName
image

Affected Component

ui5-date-picker

Expected Behaviour

  1. There should not be AXE Errors
  2. "Open picker" button should have aria-label associated with date picker accessibleName

Isolated Example

https://stackblitz.com/edit/github-pzxshp

Steps to Reproduce

  1. Go to https://stackblitz.com/edit/github-pzxshp
  2. Open date picker dialog
  3. Run AXE Devtools
  4. See there are some issues reported

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.

Activity

  1. ksblklu02
    added
    bugThis issue is a bug in the code
    on Jun 12, 2024
  2. unazko
    self-assigned this
    on Jun 12, 2024
  3. unazko
    added
    TOPIC B
    SF_ACC
    Medium Prio
    1.24
    on Jun 12, 2024

  4. unazko commented on Jun 12, 2024

    @unazko
    unazko
    on Jun 12, 2024
    Contributor

    Hello @SAP/ui5-webcomponents-topic-b,

    There are AXE tool reports for the ui5-date-picker component.

    Additionally there are already the following PRs that would fix some of the issues:

    • 8693 related to issue 1 - needs a transport
    • 9125 transport done for issue 2
    • We need to discuss issue 3 with the accessibility experts.

    Best regards,
    Boyan

  5. ilhan007
    added a commit that references this issue on Jun 18, 2024

    fix(ui5-date-picker): provide accessible name to the popover (#8693) (#…

    e53dd2d
  6. ilhan007
    modified the milestones: 1.24.5, 1.24.6 on Jun 18, 2024
  7. petyabegovska
    added this to Maintenance - Topic Bon Jun 21, 2024
  8. petyabegovska
    moved this to In Progress in Maintenance - Topic Bon Jun 21, 2024

  9. unazko commented on Jun 21, 2024

    @unazko
    unazko
    on Jun 21, 2024
    Contributor

    Hello @ksblklu02,

    Transport for issue 1 into 1.24 is done:
    #9221

    Best regards,
    Boyan

  10. ilhan007
    modified the milestones: 1.24.6, 1.24.7, 1.24.8 on Jul 3, 2024

  11. unazko commented on Jul 15, 2024

    @unazko
    unazko
    on Jul 15, 2024
    Contributor

    Hello @ksblklu02,

    The fixes are already done for issue 1 and issue 2 from the report.
    Regarding issue 3 we had a discussion among the accessibility expert group and I've got the following as feedback:

    • The value help icon has press handler therefore it needs role button as specified.
    • The value help icon is also hidden from the assistive technologies according to the specification and the following note in the standard: aria-hidden. We'll have a visual tooltip, but the redundant label won't be announced in this case as we do have a shortcut announcements through the input field.

    AXE tool doesn't report a violation in relation to issue 3 and based on the upper explanations the component behaves as specified.

    Best regards.
    Boyan

  12. unazko
    closed this as completedon Jul 15, 2024
  13. github-project-automation
    moved this from In Progress to Completed in Maintenance - Topic Bon Jul 15, 2024
  14. Shegox
    added this to Maintenance - Topic Bon Sep 5, 2025
  15. Shegox
    moved this to Completed in Maintenance - Topic Bon Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

1.24Medium PrioSF_ACCTOPIC BbugThis issue is a bug in the code

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions