Repository navigation
fix(ui5-date-picker): provide accessible name to the popover - #8693
Merged
Merged
Conversation
unazko
requested review from
GerganaKremenska
and removed request for
elenastoyanovaa
June 6, 2024 09:59
GerganaKremenska
left a comment
GerganaKremenska
left a comment
Contributor
There was a problem hiding this comment.
All pickers have labels
BorisDafov
reviewed
Jun 10, 2024
BorisDafov
left a comment
BorisDafov
left a comment
There was a problem hiding this comment.
I approve the PR from UA perspective
tsanislavgatev
approved these changes
Jun 11, 2024
tsanislavgatev
left a comment
tsanislavgatev
left a comment
Contributor
There was a problem hiding this comment.
Codewise looks good to me, If everything is okay on ACC side, we're good to go.
unazko
marked this pull request as ready for review
June 11, 2024 13:16
1 task done
unazko
added a commit
to unazko/ui5-webcomponents
that referenced
this pull request
Jun 14, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jun 14, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jun 18, 2024
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8598